Conversation
radugheo
force-pushed
the
chore/add-streamable-http-samples
branch
from
f50a1ec to
f8a659f
Compare
radugheo
force-pushed
the
chore/add-streamable-http-samples
branch
from
f8a659f to
bb327e7
Compare
There was a problem hiding this comment.
Pull request overview
This pull request adds two new MCP server implementations (string operations and datetime operations) as both testcases and samples, along with updates to the existing ground-to-cloud testcase.
Changes:
- Added string-server and datetime-server testcases with integration tests
- Added mcp-string-server and mcp-datetime-server samples demonstrating streamable HTTP transport
- Added
uipath initstep to ground-to-cloud testcase - Updated .gitignore to exclude generated files from samples
Reviewed changes
Copilot reviewed 25 out of 26 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| testcases/string-server/* | New testcase for string manipulation MCP server with stdio transport |
| testcases/datetime-server/* | New testcase for datetime operations MCP server with stdio transport |
| samples/mcp-string-server/* | New sample demonstrating string operations MCP server with streamable HTTP transport |
| samples/mcp-datetime-server/* | New sample demonstrating datetime operations MCP server with streamable HTTP transport |
| testcases/ground-to-cloud/run.sh | Added uipath init initialization step |
| .gitignore | Added patterns to exclude generated sample files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
radugheo
force-pushed
the
chore/add-streamable-http-samples
branch
2 times, most recently
from
b10807f to
a940ff1
Compare
radugheo
force-pushed
the
chore/add-streamable-http-samples
branch
from
a940ff1 to
439fd7f
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 27 out of 28 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Generate dynamic values | ||
| PR_NUMBER=${GITHUB_PR_NUMBER:-"local"} | ||
| UNIQUE_ID=$(cat /proc/sys/kernel/random/uuid) | ||
| MCP_SERVER_NAME="stringmcp-${PR_NUMBER}" | ||
|
|
||
| echo "Updating uipath.json with dynamic values... PR Number: $PR_NUMBER, MCP Server Name: $MCP_SERVER_NAME, Unique ID: $UNIQUE_ID" | ||
|
|
||
| # Remove empty tenantId line if exists | ||
| sed -i '/^UIPATH_TENANT_ID=[[:space:]]*$/d' .env | ||
|
|
||
| # Replace placeholders in uipath.json using sed | ||
| sed -i "s/PRNUMBER/$PR_NUMBER/g" mcp.json | ||
| sed -i "s/PRNUMBER/$PR_NUMBER/g" uipath.json | ||
| sed -i "s/a1b2c3d4-5678-9abc-def0-1234567890ab/$UNIQUE_ID/g" uipath.json | ||
|
|
There was a problem hiding this comment.
This script generates UNIQUE_ID and runs sed replacements for a UUID placeholder in uipath.json, but the committed uipath.json in this testcase does not contain that placeholder (or any PRNUMBER/uniqueId fields). This makes the UUID generation and related sed line dead code and can confuse debugging; either remove the unused UUID logic or add/maintain matching placeholders in uipath.json so the substitutions are meaningful.
This pull request introduces two new sample MCP servers: one for date/time operations and one for string operations, along with corresponding test cases and configuration files.