Merged
Conversation
DragosBobolea
requested changes
Feb 26, 2026
Member
DragosBobolea
left a comment
DragosBobolea
left a comment
There was a problem hiding this comment.
please add tests to prevent future regressions
cosminacho
force-pushed
the
fix/fix_binding_kwargs_bedrock
branch
3 times, most recently
from
65c7d89 to
f285df1
Compare
ionut-mihalache-uipath
approved these changes
Feb 27, 2026
cotovanu-cristian
force-pushed
the
fix/fix_binding_kwargs_bedrock
branch
from
f285df1 to
c5163a8
Compare
cotovanu-cristian
approved these changes
Feb 27, 2026
Collaborator
we would need some integration tests here testing multiple scenarios using these clients and their parameters |
DragosBobolea
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.