Creilly11235/vertex shell sidebar provider migration#577
Open
creilly11235 wants to merge 1 commit intomainfrom
Open
Creilly11235/vertex shell sidebar provider migration#577creilly11235 wants to merge 1 commit intomainfrom
creilly11235 wants to merge 1 commit intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Dependency License Review
License distribution
Excluded packages
|
This was referenced Apr 24, 2026
creilly11235
force-pushed
the
creilly11235/vertex-shell-sidebar-provider-migration
branch
from
5eb844d to
d161a9c
Compare
This was referenced Apr 24, 2026
alincadariu
requested changes
Apr 24, 2026
Comment on lines
-28
to
-31
| const [isCollapsed, setIsCollapsed] = useLocalStorage<boolean>({ | ||
| key: SIDEBAR_COLLAPSED_KEY, | ||
| defaultValue: false, | ||
| }); |
Collaborator
There was a problem hiding this comment.
up until now the state of the sidebar (open/close) was stored in the local storage, such that on a refresh the sidebar would be in the state before the refresh. now its not anymore. we should bring this behaviour back
creilly11235
force-pushed
the
creilly11235/vertex-shell-sidebar-provider-migration
branch
from
d161a9c to
6328f62
Compare
creilly11235
requested review from
KokoMilev and
alincadariu
and removed request for
a team
creilly11235
force-pushed
the
creilly11235/vertex-shell-sidebar-provider-migration
branch
from
6328f62 to
a8db5fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch to using shadcn-based sidebar component. This PR swaps the hand built sidebar we currently have in the shell and adds the sub-nav capabilities. Demo docs and preview updates are in a separate pr to keep this one small. This PR is not dependent on #576 but without #576 it breaks the preview in the docs.