feat: improve PM notifier run-local script#4933
Merged
Conversation
Signed-off-by: Matt Rice <matthewcrice32@gmail.com>
mrice32
requested review from
Reinis-FRP,
chrismaree and
md0x
as code owners
Reinis-FRP
reviewed
Feb 24, 2026
Reinis-FRP
reviewed
Feb 24, 2026
| error "bot-configs path is required" | ||
| exit 1 | ||
| fi | ||
| UMA_BOT_CONFIGS="$(mktemp -d)/bot-configs" |
Contributor
There was a problem hiding this comment.
not that comfortable having sensitive env values in the /tmp, better to delete it immediately upon creating .env.local and/or exit trap
Member
Author
There was a problem hiding this comment.
Hmmm, that's fair. I think mktemp is generally fairly safe since it sets the permissions restrictively, but we can delete it after so we avoid it sticking around. That's a fair compromise I think.
Thoughts?
md0x
previously approved these changes
Feb 24, 2026
Contributor
md0x
left a comment
md0x
left a comment
There was a problem hiding this comment.
LGTM, including @Reinis-FRP suggestions.
Co-authored-by: Reinis Martinsons <77973553+Reinis-FRP@users.noreply.github.com>
Co-authored-by: Reinis Martinsons <77973553+Reinis-FRP@users.noreply.github.com>
The bot-configs repo contains sensitive data, so delete the temporary clone once it's no longer needed for .env generation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Reinis-FRP
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should all make the script faster to use in a pinch.