docs(ui5-breadcrumbs): correct @since for accessibleName#13722
Open
dobrinyonkov wants to merge 1 commit into
Open
docs(ui5-breadcrumbs): correct @since for accessibleName#13722dobrinyonkov wants to merge 1 commit into
dobrinyonkov wants to merge 1 commit into
Conversation
dobrinyonkov
temporarily deployed
to
netlify-preview
GitHub Actions
Inactive
|
🚀 Deployed on https://pr-13722--ui5-webcomponents-preview.netlify.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
accessibleNameproperty onui5-breadcrumbswas documented as@since 2.22.0, which is incorrect — 2.22.0 has already been released and the property was not part of it.Evidence
9b6fea73654("fix(ui5-breadcrumbs): acc findings fixed"), which landed after the 2.23.0 release branch was cut.package.jsonis2.24.0-rc.1; the latest released git tag isv2.23.1.accessibleNamewill be 2.24.0.Change
Single-line JSDoc fix in
packages/main/src/Breadcrumbs.ts:Surfaced during the API review ahead of the upcoming 2.24.0 release.