Skip to content

fix(ui5-shellbar): acc findings fixed #13556

Open
PetyaMarkovaBogdanova wants to merge 2 commits into
mainfrom
fix-acc-sb
Open

fix(ui5-shellbar): acc findings fixed #13556
PetyaMarkovaBogdanova wants to merge 2 commits into
mainfrom
fix-acc-sb

Conversation

@PetyaMarkovaBogdanova

@PetyaMarkovaBogdanova PetyaMarkovaBogdanova commented May 20, 2026

Copy link
Copy Markdown
Contributor

5) ShellBar

  • Dialog section without computable accessible name: fixed by adding accessibleName to the overflow popover.
Component Issue Not by spec Good to have Spec refs Spec quote sentence Coverage strength
ShellBar Dialog without accessible name Yes No ACC-253, ACC-264 "the dialog 'title' should be associated with the container having role=dialog using aria-labelledby" Direct

@ui5-webcomponents-bot

ui5-webcomponents-bot commented May 20, 2026

Copy link
Copy Markdown
Collaborator

@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview May 20, 2026 07:08 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview May 20, 2026 07:22 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview May 20, 2026 12:22 Inactive
@PetyaMarkovaBogdanova PetyaMarkovaBogdanova changed the title Fix acc sb fix(ui5-shellbar): acc findings fixed May 20, 2026
@PetyaMarkovaBogdanova PetyaMarkovaBogdanova marked this pull request as ready for review May 20, 2026 14:30
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview June 1, 2026 13:44 Inactive
@dobrinyonkov

Copy link
Copy Markdown
Contributor

🟡 Minor — Rule 270 (aria-required on switch host) claimed in PR description is not in this diff

The PR body lists three rule violations, but only Rule 281 (aria-expanded on button host) and Rule 736 (dialog without accessible name) are addressed here. Either:

  • Update the PR description to scope it to "search button + overflow dialog", or
  • Add the switch fix (the offender is likely in a different template — worth a quick grep).

Not a defect in what's shipped, just a description/scope mismatch worth resolving before merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants