Fix dotfiles install (#45) and upgrade to PHP 8.4#48
Open
kurowski wants to merge 2 commits into
Open
Conversation
Anchor lifecycle scripts to $WORKSPACE_FOLDER at entry and exit so the shellServer's cwd stays valid for subsequent steps — including the devcontainer CLI's own dotfiles install, which previously failed with "Unable to read current working directory" after onCreate work invalidated the inode the shellServer had cd'd into. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$WORKSPACE_FOLDERon entry and exit, so the shellServer's cwd stays valid for the devcontainer CLI's dotfiles install step.mcr.microsoft.com/devcontainers/php:8.3to:8.4.Test plan
dck && dcewith--dotfiles-repositoryset against a fresh container — dotfiles clone succeeds, no exit 128.~/.devcontainer/.dotfilesMarkerand~/dotfiles/both populated after firstdevcontainer up.🤖 Generated with Claude Code