fix: forward cache-mode and disable-restore-keys to Cypress composite actions#225
Conversation
… actions The run-cypress-functional and run-cypress-visual composite actions were not forwarding cache-mode and disable-restore-keys inputs to setup-node-with-cache. This caused projects like hall-of-forms that set cache-mode: 'node_modules-only' to fall back to the default 'full' mode in Cypress jobs, resulting in mismatched cache keys, stale asdf restore-key fallback, hundreds of tar errors during extraction (~3-5 min wasted), and job timeouts at the 20-minute limit. Changes: - Add cache-mode and disable-restore-keys inputs to run-cypress-functional - Add cache-mode and disable-restore-keys inputs to run-cypress-visual - Forward both inputs to setup-node-with-cache in both composite actions - Forward both inputs from frontend-deploy-workflow Cypress jobs - Forward both inputs from frontend-pr-workflow Cypress jobs Fixes hall-of-forms release workflow Cypress Functional timeout.
e1d8b09 to
0d2f271
Compare
|
This PR is missing a Jira ticket reference in the title or description. |
|
🥷 Code experts: no user but you matched threshold 10 kb-typeform has most 👩💻 activity in the files. See details
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame: ✨ Comment |
Overview
Fix hall-of-forms Cypress Functional job timing out at the 20-minute limit on release workflows. The
run-cypress-functionalandrun-cypress-visualcomposite actions were not forwardingcache-modeanddisable-restore-keysinputs tosetup-node-with-cache, causing projects that setcache-mode: "node_modules-only"(like hall-of-forms) to fall back to the default"full"mode in Cypress jobs.This resulted in mismatched cache keys → stale asdf restore-key fallback → hundreds of tar errors during extraction (~3-5 min wasted) → job timeout.
Changes
cache-modeanddisable-restore-keysinputs torun-cypress-functional/action.ymland forward them tosetup-node-with-cachecache-modeanddisable-restore-keysinputs torun-cypress-visual/action.ymland forward them tosetup-node-with-cachefrontend-deploy-workflow.ymlCypress jobs to the composite actionsfrontend-pr-workflow.ymlCypress jobs to the composite actionsBackward Compatibility
Both new inputs default to
"full"/"false"respectively, matching the existingsetup-node-with-cachedefaults. No changes needed in calling repos that do not set these inputs.Testing
After merging, trigger a hall-of-forms release to verify: