Skip to content

fix: forward cache-mode and disable-restore-keys to Cypress composite actions#225

Merged
kb-typeform merged 1 commit intomainfrom
fix/cypress-cache-mode-forwarding
Apr 14, 2026
Merged

fix: forward cache-mode and disable-restore-keys to Cypress composite actions#225
kb-typeform merged 1 commit intomainfrom
fix/cypress-cache-mode-forwarding

Conversation

@kb-typeform
Copy link
Copy Markdown
Contributor

Overview

Fix hall-of-forms Cypress Functional job timing out at the 20-minute limit on release workflows. The run-cypress-functional and run-cypress-visual composite actions were not forwarding cache-mode and disable-restore-keys inputs to setup-node-with-cache, causing projects that set cache-mode: "node_modules-only" (like hall-of-forms) to fall back to the default "full" mode in Cypress jobs.

This resulted in mismatched cache keys → stale asdf restore-key fallback → hundreds of tar errors during extraction (~3-5 min wasted) → job timeout.

Changes

  • Add cache-mode and disable-restore-keys inputs to run-cypress-functional/action.yml and forward them to setup-node-with-cache
  • Add cache-mode and disable-restore-keys inputs to run-cypress-visual/action.yml and forward them to setup-node-with-cache
  • Forward both inputs from frontend-deploy-workflow.yml Cypress jobs to the composite actions
  • Forward both inputs from frontend-pr-workflow.yml Cypress jobs to the composite actions

Backward Compatibility

Both new inputs default to "full" / "false" respectively, matching the existing setup-node-with-cache defaults. No changes needed in calling repos that do not set these inputs.

Testing

After merging, trigger a hall-of-forms release to verify:

  1. Cache restore completes without tar errors
  2. Cypress Functional job finishes within the 20-minute timeout
  3. Cache keys match between build and Cypress jobs

… actions

The run-cypress-functional and run-cypress-visual composite actions were
not forwarding cache-mode and disable-restore-keys inputs to
setup-node-with-cache. This caused projects like hall-of-forms that set
cache-mode: 'node_modules-only' to fall back to the default 'full' mode
in Cypress jobs, resulting in mismatched cache keys, stale asdf
restore-key fallback, hundreds of tar errors during extraction (~3-5 min
wasted), and job timeouts at the 20-minute limit.

Changes:
- Add cache-mode and disable-restore-keys inputs to run-cypress-functional
- Add cache-mode and disable-restore-keys inputs to run-cypress-visual
- Forward both inputs to setup-node-with-cache in both composite actions
- Forward both inputs from frontend-deploy-workflow Cypress jobs
- Forward both inputs from frontend-pr-workflow Cypress jobs

Fixes hall-of-forms release workflow Cypress Functional timeout.
@kb-typeform kb-typeform force-pushed the fix/cypress-cache-mode-forwarding branch from e1d8b09 to 0d2f271 Compare April 14, 2026 09:28
@kb-typeform kb-typeform marked this pull request as ready for review April 14, 2026 09:28
@kb-typeform kb-typeform requested a review from a team as a code owner April 14, 2026 09:28
@kb-typeform kb-typeform merged commit 4da12c2 into main Apr 14, 2026
7 checks passed
@gitstream-cm
Copy link
Copy Markdown

gitstream-cm bot commented Apr 14, 2026

This PR is missing a Jira ticket reference in the title or description.
Please add a Jira ticket reference to the title or description of this PR.

@gitstream-cm
Copy link
Copy Markdown

gitstream-cm bot commented Apr 14, 2026

🥷 Code experts: no user but you matched threshold 10

kb-typeform has most 👩‍💻 activity in the files.
kb-typeform has most 🧠 knowledge in the files.

See details

.github/workflows/frontend-deploy-workflow.yml

Activity based on git-commit:

kb-typeform
APR 4 additions & 0 deletions
MAR 59 additions & 31 deletions
FEB 374 additions & 9 deletions
JAN 9 additions & 1 deletions
DEC 292 additions & 12 deletions
NOV

Knowledge based on git-blame:
kb-typeform: 98%

.github/workflows/frontend-pr-workflow.yml

Activity based on git-commit:

kb-typeform
APR 4 additions & 0 deletions
MAR 65 additions & 28 deletions
FEB 273 additions & 92 deletions
JAN
DEC 458 additions & 16 deletions
NOV

Knowledge based on git-blame:
kb-typeform: 92%

shared-actions/run-cypress-functional/action.yml

Activity based on git-commit:

kb-typeform
APR 10 additions & 0 deletions
MAR
FEB 111 additions & 0 deletions
JAN
DEC
NOV

Knowledge based on git-blame:
kb-typeform: 98%

shared-actions/run-cypress-visual/action.yml

Activity based on git-commit:

kb-typeform
APR 10 additions & 0 deletions
MAR
FEB 134 additions & 0 deletions
JAN
DEC
NOV

Knowledge based on git-blame:
kb-typeform: 98%

✨ Comment /gs review for LinearB AI review. Learn how to automate it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant