vulkan: add getter for Allocation::memory_type_index#300
Open
janis-bhm wants to merge 1 commit intoTraverse-Research:mainfrom
Open
vulkan: add getter for Allocation::memory_type_index#300janis-bhm wants to merge 1 commit intoTraverse-Research:mainfrom
janis-bhm wants to merge 1 commit intoTraverse-Research:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When reusing allocations for aliasing or rebinding it's useful to know that the memory type of the allocation is actually compatible with the memory requirements of the resource-to-bind, and since the allocation internally carries this information I think it makes sense to expose it.
I haven't looked at whether or not this is something that should be done for dx12 and metal as well since I'm not very familiar with those APIs.