Fix/1076 logit lens layer norm#1180
Open
evcyen wants to merge 4 commits intoTransformerLensOrg:devfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1076
Issue: Logit lens with
accumulated_resid(..., apply_ln=True)gave wrong probabilities and entropy (early layers looked almost uniform instead of peaked).Root cause:
apply_ln_to_stackused the final layer’s scale (ln_final.hook_scale) for every layer. Early layers were normalized with a scale that didn’t match their own residual.Fix:
apply_ln_to_stacknow supportsrecompute_ln. Whenrecompute_ln=Trueand the target is the final layer, each slice is normalized withmodel.ln_finalusing statistics from that slice.accumulated_resid(..., apply_ln=True)callsapply_ln_to_stack(..., recompute_ln=True)for the final layer so logit lens uses per-layer normalization. Other callers keeprecompute_ln=Falseto keep the single cached scale.Type of change
Checklist