Skip to content

refactor(WWLib): Qualify library and download header includes#2876

Open
CryoTheRenegade wants to merge 1 commit into
TheSuperHackers:mainfrom
CryoTheRenegade:refactor/wwvegas-wwlib-download
Open

refactor(WWLib): Qualify library and download header includes#2876
CryoTheRenegade wants to merge 1 commit into
TheSuperHackers:mainfrom
CryoTheRenegade:refactor/wwvegas-wwlib-download

Conversation

@CryoTheRenegade

@CryoTheRenegade CryoTheRenegade commented Jul 15, 2026

Copy link
Copy Markdown

PR should be Squashed and Merged

This is the fourth in a series of PRs I am working on that migrate all of the header paths into the correct header paths.

Qualifies cross-component header includes in WWLib and WWDownload implementation files.

@greptile-apps

greptile-apps Bot commented Jul 15, 2026

Copy link
Copy Markdown

Greptile Summary

This PR qualifies cross-component WWLib and WWDownload header includes.

  • Updates WWDownload imports to use WWLib/ paths.
  • Updates WWLib implementation imports to use WWDebug/ paths.
  • Leaves public headers and CMake include-directory exports unchanged.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Important Files Changed

Filename Overview
Core/Libraries/Source/WWVegas/WWDownload/Download.cpp Qualifies the WWLib string helper include.
Core/Libraries/Source/WWVegas/WWDownload/FTP.cpp Qualifies the WWLib common header include.
Core/Libraries/Source/WWVegas/WWDownload/registry.cpp Qualifies the WWLib Windows helper include.
Core/Libraries/Source/WWVegas/WWLib/Except.cpp Qualifies WWDebug imports in the Windows exception implementation.
Core/Libraries/Source/WWVegas/WWLib/bufffile.cpp Qualifies the WWDebug include.
Core/Libraries/Source/WWVegas/WWLib/cpudetect.cpp Qualifies the WWDebug include.
Core/Libraries/Source/WWVegas/WWLib/hash.cpp Qualifies the WWDebug include.
Core/Libraries/Source/WWVegas/WWLib/lzo.cpp Qualifies the WWDebug include.
Core/Libraries/Source/WWVegas/WWLib/lzo1x_c.cpp Qualifies the WWDebug include.
Core/Libraries/Source/WWVegas/WWLib/multilist.cpp Qualifies the WWDebug memory-log include.
Core/Libraries/Source/WWVegas/WWLib/mutex.cpp Qualifies the WWDebug include.
Core/Libraries/Source/WWVegas/WWLib/tgatodxt.cpp Qualifies a WWDebug include in disabled code.
Core/Libraries/Source/WWVegas/WWLib/thread.cpp Qualifies the WWDebug include.
Core/Libraries/Source/WWVegas/WWLib/wwstring.cpp Qualifies the WWDebug memory-log include.

Reviews (2): Last reviewed commit: "refactor(WWLib): Qualify library and dow..." | Re-trigger Greptile

Comment thread Core/Libraries/Source/WWVegas/WWLib/wwstring.h Outdated
Comment thread Core/Libraries/Source/WWVegas/WWLib/DbgHelpLoader.h Outdated
@CryoTheRenegade CryoTheRenegade force-pushed the refactor/wwvegas-wwlib-download branch from f38114b to 479444a Compare July 15, 2026 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant