refactor(WWAudio): Qualify audio and debug header includes#2875
Open
CryoTheRenegade wants to merge 1 commit into
Open
refactor(WWAudio): Qualify audio and debug header includes#2875CryoTheRenegade wants to merge 1 commit into
CryoTheRenegade wants to merge 1 commit into
Conversation
|
| Filename | Overview |
|---|---|
| Core/Libraries/Source/WWVegas/WWAudio/AudibleSound.h | Qualifies WWLib, WWMath, and WWSaveLoad header dependencies. |
| Core/Libraries/Source/WWVegas/WWAudio/SoundSceneObj.cpp | Qualifies WW3D2 and WWSaveLoad header dependencies. |
| Core/Libraries/Source/WWVegas/WWDebug/wwprofile.h | Changes the public WWLib include to require the WWVegas parent include root. |
| Core/Libraries/Source/WWVegas/WWDebug/wwprofile.cpp | Qualifies WWLib dependencies used by the profiling implementation. |
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
Core/Libraries/Source/WWVegas/WWDebug/wwprofile.h:40
**Standalone header loses include root**
When a consumer exposes `WWLib` as an include directory but not the WWVegas parent directory, the old `#include "wwstring.h"` resolves while `#include "WWLib/wwstring.h"` does not. This makes direct users of the WWDebug profiling header fail to compile unless their target include directories are updated with the new parent-root requirement.
Reviews (1): Last reviewed commit: "refactor(WWAudio): Qualify audio and deb..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR should be Squashed and Merged
This is the third in a series of PRs I am working on that migrate all of the header paths into the correct header paths.
Qualifies cross-component header includes throughout WWAudio and WWDebug with their owning WWVegas component paths.