Skip to content

refactor(WWAudio): Qualify audio and debug header includes#2875

Open
CryoTheRenegade wants to merge 1 commit into
TheSuperHackers:mainfrom
CryoTheRenegade:refactor/wwvegas-audio-debug
Open

refactor(WWAudio): Qualify audio and debug header includes#2875
CryoTheRenegade wants to merge 1 commit into
TheSuperHackers:mainfrom
CryoTheRenegade:refactor/wwvegas-audio-debug

Conversation

@CryoTheRenegade

@CryoTheRenegade CryoTheRenegade commented Jul 14, 2026

Copy link
Copy Markdown

PR should be Squashed and Merged

This is the third in a series of PRs I am working on that migrate all of the header paths into the correct header paths.

Qualifies cross-component header includes throughout WWAudio and WWDebug with their owning WWVegas component paths.

@greptile-apps

greptile-apps Bot commented Jul 14, 2026

Copy link
Copy Markdown

Greptile Summary

This PR qualifies WWAudio and WWDebug cross-component header includes. The main changes are:

  • Adds WWLib, WWMath, WWSaveLoad, WWDebug, and WW3D2 prefixes.
  • Updates audio source and public header dependencies.
  • Updates debug and profiling header dependencies.

Confidence Score: 5/5

This looks safe to merge after confirming standalone WWDebug consumers receive the WWVegas parent include directory.

  • The aggregate WWVegas target provides the include root required by the new paths.
  • A direct WWDebug header consumer with only component-level include directories can require a build configuration update.

Core/Libraries/Source/WWVegas/WWDebug/wwprofile.h

Important Files Changed

Filename Overview
Core/Libraries/Source/WWVegas/WWAudio/AudibleSound.h Qualifies WWLib, WWMath, and WWSaveLoad header dependencies.
Core/Libraries/Source/WWVegas/WWAudio/SoundSceneObj.cpp Qualifies WW3D2 and WWSaveLoad header dependencies.
Core/Libraries/Source/WWVegas/WWDebug/wwprofile.h Changes the public WWLib include to require the WWVegas parent include root.
Core/Libraries/Source/WWVegas/WWDebug/wwprofile.cpp Qualifies WWLib dependencies used by the profiling implementation.
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
Core/Libraries/Source/WWVegas/WWDebug/wwprofile.h:40
**Standalone header loses include root**

When a consumer exposes `WWLib` as an include directory but not the WWVegas parent directory, the old `#include "wwstring.h"` resolves while `#include "WWLib/wwstring.h"` does not. This makes direct users of the WWDebug profiling header fail to compile unless their target include directories are updated with the new parent-root requirement.

Reviews (1): Last reviewed commit: "refactor(WWAudio): Qualify audio and deb..." | Re-trigger Greptile

Comment thread Core/Libraries/Source/WWVegas/WWDebug/wwprofile.h
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant