Skip to content

refactor(metaevent): Split MetaEventTranslator::translateGameMessage() into smaller functions #2758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xezon wants to merge 2 commits into
base: main
Choose a base branch
from
+241 −201
Open

refactor(metaevent): Split MetaEventTranslator::translateGameMessage() into smaller functions #2758

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfd0b03
refactor(metaevent): Split MetaEventTranslator::translateGameMessage(…
xezon May 30, 2026
ecebc99
Make private
xezon May 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions GeneralsMD/Code/GameEngine/Include/GameClient/MetaEvent.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,6 +441,16 @@ class MetaEventTranslator : public GameMessageTranslator
MetaEventTranslator();
virtual ~MetaEventTranslator() override;
virtual GameMessageDisposition translateGameMessage(const GameMessage *msg) override;

private:
void onMouseEvent(const GameMessage *msg);

void onKeyEvent(const GameMessage *msg, GameMessageDisposition &disp);
void onKeyModStateRemoved(GameMessageDisposition &disp, MappableKeyModState keyModState);
void onKeyPressed(GameMessageDisposition &disp, Int systemKeyState, MappableKeyType keyType, MappableKeyModState keyModState);

static MappableKeyType getActionKeyType(Int systemKey); ///< CRTL, ALT, SHIFT will be treated as MK_NONE
static MappableKeyModState getKeyModState(Int systemKeyState); ///< Extract CTRL, ALT, SHIFT key mod state
Comment thread
xezon marked this conversation as resolved.
};

//-----------------------------------------------------------------------------
Expand Down
Loading
Loading