-
-
Notifications
You must be signed in to change notification settings - Fork 50.5k
Simplify bin_to_hexadecimal function #14570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
5f8c528
9f2a343
6b45f70
a14ecb4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,31 +1,11 @@ | ||
| BITS_TO_HEX = { | ||
| "0000": "0", | ||
| "0001": "1", | ||
| "0010": "2", | ||
| "0011": "3", | ||
| "0100": "4", | ||
| "0101": "5", | ||
| "0110": "6", | ||
| "0111": "7", | ||
| "1000": "8", | ||
| "1001": "9", | ||
| "1010": "a", | ||
| "1011": "b", | ||
| "1100": "c", | ||
| "1101": "d", | ||
| "1110": "e", | ||
| "1111": "f", | ||
| } | ||
|
|
||
|
|
||
| def bin_to_hexadecimal(binary_str: str) -> str: | ||
| """ | ||
| Converting a binary string into hexadecimal using Grouping Method | ||
| Convert a binary string to hexadecimal. | ||
|
|
||
| >>> bin_to_hexadecimal('101011111') | ||
| '0x15f' | ||
| >>> bin_to_hexadecimal(' 1010 ') | ||
| '0x0a' | ||
| '0xa' | ||
| >>> bin_to_hexadecimal('-11101') | ||
| '-0x1d' | ||
| >>> bin_to_hexadecimal('a') | ||
|
|
@@ -37,27 +17,21 @@ def bin_to_hexadecimal(binary_str: str) -> str: | |
| ... | ||
| ValueError: Empty string was passed to the function | ||
| """ | ||
| # Sanitising parameter | ||
| binary_str = str(binary_str).strip() | ||
|
|
||
| # Exceptions | ||
| if not binary_str: | ||
| raise ValueError("Empty string was passed to the function") | ||
|
|
||
| is_negative = binary_str[0] == "-" | ||
| binary_str = binary_str[1:] if is_negative else binary_str | ||
| if not all(char in "01" for char in binary_str): | ||
| raise ValueError("Non-binary value was passed to the function") | ||
|
|
||
| binary_str = ( | ||
| "0" * (4 * (divmod(len(binary_str), 4)[0] + 1) - len(binary_str)) + binary_str | ||
| ) | ||
|
|
||
| hexadecimal = [] | ||
| for x in range(0, len(binary_str), 4): | ||
| hexadecimal.append(BITS_TO_HEX[binary_str[x : x + 4]]) | ||
| hexadecimal_str = "0x" + "".join(hexadecimal) | ||
|
|
||
| return "-" + hexadecimal_str if is_negative else hexadecimal_str | ||
| if not binary_str or not all(char in "01" for char in binary_str): | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Merging the empty string check and non-binary check into one condition Consider checking for empty string separately after stripping the sign. |
||
| raise ValueError("Non-binary value was passed to the function") | ||
| # Uses built-in int() for binary parsing and hex() for conversion | ||
| hex_str = "0x" + hex(int(binary_str, 2))[2:] | ||
|
Ewanjohndennis marked this conversation as resolved.
|
||
| if hex_str == "0x0": | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This edge case handling for "0x0" resetting is_negative to False is -0 is not a valid representation, treat as positive zeroif hex_str == "0x0": |
||
| is_negative = False | ||
| return "-" + hex_str if is_negative else hex_str | ||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.