Skip to content

Improve isogram handling by ignoring non-alphabetic characters#14250

Closed
Tithi234 wants to merge 3 commits intoTheAlgorithms:masterfrom
Tithi234:patch-17
Closed

Improve isogram handling by ignoring non-alphabetic characters#14250
Tithi234 wants to merge 3 commits intoTheAlgorithms:masterfrom
Tithi234:patch-17

Conversation

@Tithi234
Copy link
Contributor

@Tithi234 Tithi234 commented Feb 5, 2026

Describe your change:

  • Improves isogram detection by ignoring non-alphabetic characters
  • Simplifies logic while keeping the same algorithmic intent
  • Makes behavior more practical for real-world strings

What type of change is this?

  • Fix a bug or typo in an existing algorithm?

Checklist:

  • I have read CONTRIBUTING.md
  • This pull request is all my own work
  • I know that pull requests will not be merged if they fail the automated tests
  • This PR only changes one algorithm file
  • All functions and variable names follow Python naming conventions
  • All function parameters and return values are annotated with Python type hints
  • All functions have doctests that pass the automated testing

Updated docstring to clarify isogram definition and added example with non-alphabetic characters. Modified letter extraction to ignore non-alphabetic characters.
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Feb 5, 2026
@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Feb 5, 2026
@Tithi234
Copy link
Contributor Author

Tithi234 commented Feb 7, 2026

Closing this PR to keep the repository clean as the current CI checks are failing.
I’ll revisit this with a cleaner approach in the future.
Thanks to the maintainers for the review process.

@Tithi234 Tithi234 closed this Feb 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants