fix: correct error message in surfaceAreaCylinder method#7106
Merged
alxkm merged 2 commits intoTheAlgorithms:masterfrom Nov 24, 2025
Merged
fix: correct error message in surfaceAreaCylinder method#7106alxkm merged 2 commits intoTheAlgorithms:masterfrom
alxkm merged 2 commits intoTheAlgorithms:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7106 +/- ##
=========================================
Coverage 78.50% 78.50%
+ Complexity 6752 6751 -1
=========================================
Files 759 759
Lines 22402 22402
Branches 4400 4400
=========================================
Hits 17587 17587
Misses 4109 4109
Partials 706 706 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alxkm
approved these changes
Nov 24, 2025
Member
alxkm
left a comment
There was a problem hiding this comment.
Thank you for the contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
POSITIVE_RADIUStoPOSITIVE_HEIGHTin the height validation error messageWhen height parameter is invalid, the method was throwing "Must be a positive radius" instead of "Must be a positive height", which was misleading.