fix: typo in resynth_genetic argument -mutation_probability#9686
Conversation
define_cmd_args had '-mututation_probability' (extra 'u') while parse_key_args used the correct '-mutation_probability', causing the user-supplied value to be silently ignored. Signed-off-by: suhr25 <suhridmarwah07@gmail.com> Signed-off-by: Suhrid Marwah <suhridmarwah07@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses a typo in the resynth_genetic command argument within src/rmp/src/rmp.tcl. The argument was incorrectly defined as -mututation_probability instead of -mutation_probability, which caused user-provided values for this option to be ignored. The change corrects the typo, aligning the argument definition with the parser's expectation and fixing the bug. The change is correct and self-contained.
suhr25
force-pushed
the
fix/rmp-resynth-genetic-mutation-probability-typo
branch
from
0fb4de5 to
3c90df7
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
Update resynth_genetic documentation to use the full option names that match the actual Tcl implementation: -population_size, -mutation_probability, -crossover_probability, -tournament_probability, and -tournament_size. The README had abbreviated aliases that do not exist in parse_key_args and would be silently ignored if used. Signed-off-by: suhr25 <suhridmarwah07@gmail.com> Signed-off-by: Suhrid Marwah <suhridmarwah07@gmail.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
|
Hi @eder-matheus, |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
@suhr25 Check the DCO error. |
Signed-off-by: Suhrid Marwah <suhridmarwah07@gmail.com>
Head branch was pushed to by a user without write access
suhr25
force-pushed
the
fix/rmp-resynth-genetic-mutation-probability-typo
branch
from
08d6a85 to
0e5a112
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
|
Hi @eder-matheus, |
3 participants
SUMMARY
Fixes a typo in the
resynth_geneticargument definition insrc/rmp/src/rmp.tcl. The option was documented as-mututation_probabilitywhile the parser expects-mutation_probability, causing the user value to be ignored.FIX
Correct the typo in
define_cmd_argsso it matches the parser.Before
After
VERIFICATION
Run:
Expected: the argument is recognized and the mutation probability value is applied.