docs(linux): Add PTP support documentation for HSR and PRP offload#644
Open
danish-ti wants to merge 1 commit intoTexasInstruments:masterfrom
Open
docs(linux): Add PTP support documentation for HSR and PRP offload#644danish-ti wants to merge 1 commit intoTexasInstruments:masterfrom
danish-ti wants to merge 1 commit intoTexasInstruments:masterfrom
Conversation
danish-ti
requested review from
StaticRocket,
VeeruPrudhvi,
cshilwant,
gehariprasath,
jeevantelukula,
praneethbajjuri and
uditkumarti
as code owners
github-actions
bot
assigned
danish-ti,
devarsht,
gehariprasath,
praneethbajjuri,
r-vignesh,
Siddharth-Vadapalli-at-TI and
uditkumarti
StaticRocket
requested changes
Apr 6, 2026
Member
StaticRocket
left a comment
StaticRocket
left a comment
There was a problem hiding this comment.
I would almost prefer this block be moved to it's own include file considering it's the same between the two offload mechanisms.
source/linux/Foundational_Components/Kernel/Kernel_Drivers/Network/HSR_Offload.rst
Outdated
Show resolved
Hide resolved
|
New warnings found with rstcheck: |
danish-ti
force-pushed
the
latest
branch
2 times, most recently
from
609c1a7 to
8767b6a
Compare
Contributor
Author
@StaticRocket I have moved the PTP documentation to separate doc and just refering it in both HSR and PRP docs. Please review and approve. |
StaticRocket
requested changes
Apr 7, 2026
source/linux/Foundational_Components/Kernel/Kernel_Drivers/Network/HSR_PRP_PTP.rst
Outdated
Show resolved
Hide resolved
StaticRocket
reviewed
Apr 8, 2026
| address. The config files use INI-style sections where ``[eth1]`` and ``[eth2]`` | ||
| denote the two physical interfaces. The first command appends the ``p2p_dst_mac`` | ||
| key (destination MAC for P2P delay-request messages) into the | ||
| ``[delay_mechanism P2P]`` section. The second command replaces the ``[eth1]`` and |
Member
There was a problem hiding this comment.
Suggested change
| ``[delay_mechanism P2P]`` section. The second command replaces the ``[eth1]`` and | |
| ``[global]`` section just after the ``delay_mechanism`` key. The second command replaces the ``[eth1]`` and |
Member
There was a problem hiding this comment.
Also, shouldn't that regex just match the key? Matching the key and the value seems unnecessary.
Contributor
Author
There was a problem hiding this comment.
yes. Matching only key is enough. I will update PR with your suggestion.
Member
|
I didn't notice it earlier, but https://github.com/TexasInstruments/processor-sdk-doc/blob/master/CONTRIBUTING.md#commit-formatting |
Add a new standalone page HSR_PRP_PTP.rst documenting PTP synchronization support for HSR and PRP interfaces using the linuxptp-hsr implementation (hsr_prp_v2_plus branch). The page covers: - Cloning and building linuxptp-hsr - Patching config files with interface names and p2p_dst_mac - Running ptp4l with primary/secondary configs - Verifying sync via master offset values HSR_Offload.rst and PRP_Offload.rst each get a brief PTP Support section with a cross-reference to the new page. HSR_PRP_PTP.rst is added to the toctree in Foundational_Components_Kernel_Drivers.rst. Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document PTP synchronization support over HSR and PRP interfaces using the linuxptp-hsr implementation (hsr_prp_v2_plus branch).
Add Prerequisites, Running PTP, and Verifying PTP Synchronization subsections to both HSR_Offload.rst and PRP_Offload.rst covering: