refactor(hw-setup): remove unnecessary includes#624
Open
StaticRocket wants to merge 1 commit intoTexasInstruments:masterfrom
Open
refactor(hw-setup): remove unnecessary includes#624StaticRocket wants to merge 1 commit intoTexasInstruments:masterfrom
StaticRocket wants to merge 1 commit intoTexasInstruments:masterfrom
Conversation
Replace these 1 line include files with a TOC tree pointer to the primary file. This can help with switching between distro builds as the path of common files no longer changes. We currently have 2 different mechanisms to complicate things. One is the TOC tree, the other is arbitrary includes. Modifying the TOC tree is a little hard to parse ahead of time, but it results in a lower likelihood of accidentally creating duplicate content. Using includes results in more files and a deeper file chain you need to parse, but it is clearer ahead of time what is occurring. I'm in favor of using the TOC tree since that's where a lot of complexity already resides. Signed-off-by: Randolph Sapp <rs@ti.com>
|
New warnings found with rstcheck: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace these 1 line include files with a TOC tree pointer to the primary file. This can help with switching between distro builds as the path of common files no longer changes.
We currently have 2 different mechanisms to complicate things. One is the TOC tree, the other is arbitrary includes. Modifying the TOC tree is a little hard to parse ahead of time, but it results in a lower likelihood of accidentally creating duplicate content. Using includes results in more files and a deeper file chain you need to parse, but it is clearer ahead of time what is occurring.
I'm in favor of using the TOC tree since that's where a lot of complexity already resides.