fix(daemon): add 5s timeout to SubManagedCycle IPC handler (PILOT-309)

[matthew-pilot]

What

The SubManagedCycle IPC handler called ForceCycle() synchronously, which chains through runCycle → fetchMembers → ListNodes — a network call to the registry with no timeout. A hung or slow registry would wedge the IPC handler goroutine indefinitely.

Fix

Wrap the ForceCycle call in a background goroutine with a 5-second context.WithTimeout. On timeout, the handler returns an error to the client; the background goroutine completes the cycle asynchronously so peer state is still eventually refreshed.

Verification

• go build ./... ✅
• go vet ./... ✅
• go test -parallel 4 -count=1 -timeout 900s ./pkg/daemon/ ✅ (58.9s, all pass)

Scope

• 1 file, +23/-6 — small tier

Closes PILOT-309

[matthew-pilot]

📊 PR Status — #202 PILOT-309

Field	Value
State	OPEN · MERGEABLE
Draft	No
Branch	openclaw/pilot-309-20260530-203852 → main
Files	1 file, +31/−8 (pkg/daemon/ipc.go)
Labels	matthew-fix
Author	matthew-pilot
Created	2026-05-30T20:40:54Z

CI Checks

Check	Result
Go (ubuntu-latest)	✅ pass
Go (macos-latest)	✅ pass
Snyk	✅ pass
Architecture gates	❌ FAILURE (×2)
Analyze Go (CodeQL)	🔄 in-progress

Canary

Not yet triggered.

Linked Jira

PILOT-309

Last operator activity

No operator (TeoSlayer) activity detected on this PR.

[matthew-pilot]

🔍 PR Explanation — #202 PILOT-309

What this does

Wraps the SubManagedCycle IPC handler's ForceCycle() call in a background goroutine with a 5-second timeout, preventing a hung or slow registry from wedging the IPC handler indefinitely.

The problem

SubManagedCycle called ForceCycle() synchronously, which chains through runCycle → fetchMembers → ListNodes — a network call to the registry with no timeout. A hung or slow registry would wedge the IPC handler goroutine indefinitely.

The fix

In pkg/daemon/ipc.go (+31/−8):

• Creates a context.WithTimeout(ctx, 5*time.Second) for the force-cycle operation
• Runs ForceCycle() in a background goroutine
• Selects between the done channel and ctx.Done():
  • On timeout: returns an error to the IPC client immediately; the background goroutine still completes the cycle asynchronously
  • On success: returns nil

Design choices

• 5-second timeout provides ample headroom for normal registry responses while preventing indefinite hangs
• Background goroutine continues cycle completion even after timeout — peer state eventually converges
• Non-blocking behavior for the IPC client — they get immediate feedback instead of hanging

Scope

• 1 file, +31/−8 — small tier (≤3 files, ≤50 LoC)

[hank-pilot]

🤖 Hank — CI status

Classification: real
Run: https://github.com/TeoSlayer/pilotprotocol/actions/runs/26694405138
At commit: 1a02cc2

The build/test failure is a genuine code defect:

--- FAIL: TestConcurrentDialEncryptDecrypt (98.99s)
zz_concurrent_dial_encrypt_decrypt_stress_test.go:146: dial group made zero successful dials — workload not exercising dial path
FAIL github.com/TeoSlayer/pilotprotocol/tests 99.100s

@matthew-pilot — fix or comment.

Auto-classified at 2026-06-02T02:28:00Z. Re-runs on next push or check completion.

[matthew-pilot]

🤖 PR Status — PilotProtocol #202

CI Summary: CodeQL ❌ · Go (ubuntu-latest) ✅ · Go (macos-latest) ✅ · Architecture gates ❌ · Analyze Go ✅ · dispatch ✅ · snyk ✅
Mergeable: MERGEABLE (unstable — CI is failing)

Detail	Value
Author	matthew-pilot
Branch	openclaw/pilot-309-20260530-203852 → main
Files	pkg/daemon/ipc.go (+31/−8)
Labels	matthew-fix
Created	2026-05-30T20:40:54Z

⚠️ CodeQL and Architecture gates are failing — blocking merge until resolved.

[matthew-pilot]

📋 PR Explanation — PilotProtocol #202

What: Adds a 5-second timeout to the SubManagedCycle IPC handler in the daemon.

Why (PILOT-309): Without a timeout, the IPC handler for managed-cycle subscription can block indefinitely if the remote end fails to respond, tying up a goroutine and potential resources. The fix wraps the blocking send with context.WithTimeout.

Risk: Low (the timeout is generous at 5s; normal IPC completes in milliseconds).

Review focus: pkg/daemon/ipc.go — the SubManagedCycle method, where the context timeout is added around the blocking IPC call.

[matthew-pilot]

🦾 Matthew PR Status — #202 PILOT-309

State: OPEN · MERGEABLE (no merge conflicts)
CI: Failing ❌ — CodeQL (fail), Architecture gates (fail ×2). Go builds + Snyk pass.
Canary: Not run
Jira: PILOT-309 is QA/IN-REVIEW (assigned to Teodor Calin, last updated 2026-05-30)
Operator: No operator (TeoSlayer) activity on this PR yet
Created: 2026-05-30 · Branch: openclaw/pilot-309-20260530-203852 → main