Fixed typo in the ctor that would throw NullReferenceException for un…#54
Open
zbalkan wants to merge 1 commit intoTechnitiumSoftware:masterfrom
Open
Conversation
…bound field access instead of NotSupportedException
There was a problem hiding this comment.
Pull request overview
Fixes an exception-message bug in the OTP Authenticator constructor so unsupported URI types no longer attempt to read an uninitialized backing field.
Changes:
- Update
NotSupportedExceptionmessage to reference thekeyUriparameter instead of_keyUribefore initialization.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -43,7 +43,7 @@ public class Authenticator | |||
| public Authenticator(AuthenticatorKeyUri keyUri) | |||
| { | |||
There was a problem hiding this comment.
Authenticator(AuthenticatorKeyUri keyUri) dereferences keyUri before validating it; passing null will still throw a NullReferenceException at keyUri.Type. Consider adding ArgumentNullException.ThrowIfNull(keyUri) at the start (consistent with other constructors like AuthenticatorKeyUri and DomainEndPoint).
Suggested change
| { | |
| { | |
| ArgumentNullException.ThrowIfNull(keyUri); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…bound field access instead of NotSupportedException