Fixed typo in the TransparentProxyServer ctor#48
Open
zbalkan wants to merge 3 commits intoTechnitiumSoftware:masterfrom
Open
Fixed typo in the TransparentProxyServer ctor#48zbalkan wants to merge 3 commits intoTechnitiumSoftware:masterfrom
zbalkan wants to merge 3 commits intoTechnitiumSoftware:masterfrom
Conversation
Member
|
Thanks for the PR. Will get this merged soon. |
zbalkan
force-pushed
the
fix/Fixed-typo-in-TransparentProxyServer-ctor
branch
from
34ff492 to
4577be1
Compare
This reverts commit 4577be1.
There was a problem hiding this comment.
Pull request overview
Fixes a constructor guard clause in TransparentProxyServer so that validation checks the incoming method parameter (instead of the uninitialized _method field), restoring the intended platform/IPv4 validation behavior referenced in issue #47.
Changes:
- Corrected the constructor guard to validate
methodrather than_method.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #47