Potential fix for code scanning alert no. 6: Clear-text logging of sensitive information#5
Draft
johnteee wants to merge 1 commit into
Draft
Potential fix for code scanning alert no. 6: Clear-text logging of sensitive information#5johnteee wants to merge 1 commit into
johnteee wants to merge 1 commit into
Conversation
…nsitive information Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/TeaEntityLab/teaAgent/security/code-scanning/6
General fix: never include raw credential-bearing input in log/error text. Log a generic validation failure, optionally with non-sensitive metadata (like argument name and expected format), but not the provided value.
Best targeted fix here: in
teaagent/cli/_handlers/_mcp.py, replace the stderr print at line 47 to remove{spec}entirely. Keep functionality unchanged (still rejects malformed input and returns1), while preventing accidental secret disclosure. No new methods/imports/dependencies are required.Suggested fixes powered by Copilot Autofix. Review carefully before merging.