Update partner logos for CodeRabbit and Cloudflare by santoshyadavdev · Pull Request #1145 · TanStack/virtual

santoshyadavdev · 2026-03-12T20:10:31Z

🎯 Changes

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Documentation
- Updated partner logo imagery in the README with improved dark and light theme variants for better visual consistency across different viewing modes.

changeset-bot · 2026-03-12T20:10:43Z

⚠️ No Changeset found

Latest commit: 6d80390

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-04-26T11:09:06Z

📝 Walkthrough

Walkthrough

The README's partner logos section updates HTML picture elements for CodeRabbit and Cloudflare with new srcset asset filenames for dark/light theme variants, modified src image references, removal of height attributes from source tags, and removal of padding from the Cloudflare cell.

Changes

Cohort / File(s)	Summary
Partner Logo Markup Updates `README.md`	Updated CodeRabbit and Cloudflare `<picture>` elements with new srcset filenames for theme variants, changed `src` values on displayed images, removed `height` attributes from `<source>` tags, eliminated `padding="20"` from Cloudflare cell, and adjusted whitespace indentation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Logo pictures, freshly dressed,
New filenames—now looking their best!
Dark and light themes, side by side,
HTML tweaks with README pride! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description uses the required template structure but the 'Changes' section is empty with only a template comment, leaving the motivation and implementation details completely undocumented.	Fill in the 'Changes' section with a clear explanation of what was updated in the partner logos and why, such as srcset variants for dark/light themes or other visual improvements.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: updating partner logos for CodeRabbit and Cloudflare, which matches the file modifications in README.md.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

nx-cloud · 2026-04-26T11:09:49Z

View your CI Pipeline Execution ↗ for commit 06e9866

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	7s	View ↗
`nx run-many --target=build --exclude=examples/**`	✅ Succeeded	17s	View ↗

☁️ Nx Cloud last updated this comment at 2026-04-26 11:10:36 UTC

pkg-pr-new · 2026-04-26T11:10:04Z

More templates

@tanstack/angular-virtual

npm i https://pkg.pr.new/@tanstack/angular-virtual@1145

@tanstack/lit-virtual

npm i https://pkg.pr.new/@tanstack/lit-virtual@1145

@tanstack/react-virtual

npm i https://pkg.pr.new/@tanstack/react-virtual@1145

@tanstack/solid-virtual

npm i https://pkg.pr.new/@tanstack/solid-virtual@1145

@tanstack/svelte-virtual

npm i https://pkg.pr.new/@tanstack/svelte-virtual@1145

@tanstack/virtual-core

npm i https://pkg.pr.new/@tanstack/virtual-core@1145

@tanstack/vue-virtual

npm i https://pkg.pr.new/@tanstack/vue-virtual@1145

commit: 06e9866

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@README.md`:
- Around line 71-74: The fallback <img> currently uses the white Cloudflare
asset which will look bad on light backgrounds; update the <img> inside the
picture block (the <img src> fallback) to use the black/light variant URL
(https://tanstack.com/assets/cloudflare-black-6Ojsn8yh.svg) so clients that
ignore <picture><source> render a light-mode-safe image (you can also add a
srcset attribute mirroring the light variant if desired).

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 29989c0c-8748-4795-9d8f-3d1dbc637cc8

📥 Commits

Reviewing files that changed from the base of the PR and between e049ad9 and 06e9866.

📒 Files selected for processing (1)

README.md

coderabbitai · 2026-04-26T11:10:40Z

+          <source media="(prefers-color-scheme: dark)" srcset="https://tanstack.com/assets/cloudflare-white-Co-Tyjbl.svg" />
+          <source media="(prefers-color-scheme: light)" srcset="https://tanstack.com/assets/cloudflare-black-6Ojsn8yh.svg" />
+          <img src="https://tanstack.com/assets/cloudflare-white-Co-Tyjbl.svg" height="60" alt="Cloudflare" />
+        </picture>


⚠️ Potential issue | 🟡 Minor

Use a light-mode-safe fallback image for Cloudflare.

On Line 73, the fallback <img src> is the white asset. In clients that don’t apply <picture><source>, this can render poorly on light backgrounds. Prefer the black/light variant as fallback.

Suggested fix

- <img src="https://tanstack.com/assets/cloudflare-white-Co-Tyjbl.svg" height="60" alt="Cloudflare" /> + <img src="https://tanstack.com/assets/cloudflare-black-6Ojsn8yh.svg" height="60" alt="Cloudflare" />

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

<source media="(prefers-color-scheme: dark)" srcset="https://tanstack.com/assets/cloudflare-white-Co-Tyjbl.svg" />

<source media="(prefers-color-scheme: light)" srcset="https://tanstack.com/assets/cloudflare-black-6Ojsn8yh.svg" />

<img src="https://tanstack.com/assets/cloudflare-white-Co-Tyjbl.svg" height="60" alt="Cloudflare" />

</picture>

<source media="(prefers-color-scheme: dark)" srcset="https://tanstack.com/assets/cloudflare-white-Co-Tyjbl.svg" />

<source media="(prefers-color-scheme: light)" srcset="https://tanstack.com/assets/cloudflare-black-6Ojsn8yh.svg" />

<img src="https://tanstack.com/assets/cloudflare-black-6Ojsn8yh.svg" height="60" alt="Cloudflare" />

</picture>

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed. In `@README.md` around lines 71 - 74, The fallback <img> currently uses the white Cloudflare asset which will look bad on light backgrounds; update the <img> inside the picture block (the <img src> fallback) to use the black/light variant URL (https://tanstack.com/assets/cloudflare-black-6Ojsn8yh.svg) so clients that ignore <picture><source> render a light-mode-safe image (you can also add a srcset attribute mirroring the light variant if desired).

Update partner logos for CodeRabbit and Cloudflare

6d80390

Fix table formatting in README.md

06e9866

coderabbitai Bot reviewed Apr 26, 2026

View reviewed changes

piecyk merged commit ca8b4ba into TanStack:main Apr 26, 2026
7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update partner logos for CodeRabbit and Cloudflare#1145

Update partner logos for CodeRabbit and Cloudflare#1145
piecyk merged 2 commits intoTanStack:mainfrom
santoshyadavdev:patch-1

santoshyadavdev commented Mar 12, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

changeset-bot Bot commented Mar 12, 2026

Uh oh!

coderabbitai Bot commented Apr 26, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Poem

❌ Failed checks (1 warning)

Uh oh!

nx-cloud Bot commented Apr 26, 2026 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented Apr 26, 2026

Uh oh!

coderabbitai Bot left a comment

Uh oh!

coderabbitai Bot Apr 26, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

santoshyadavdev commented Mar 12, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

changeset-bot Bot commented Mar 12, 2026

⚠️ No Changeset found

Uh oh!

coderabbitai Bot commented Apr 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

❌ Failed checks (1 warning)

Uh oh!

nx-cloud Bot commented Apr 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new Bot commented Apr 26, 2026

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Apr 26, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

santoshyadavdev commented Mar 12, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Apr 26, 2026 •

edited

Loading

nx-cloud Bot commented Apr 26, 2026 •

edited

Loading