fix(start): upgrade rsbuild for RSC preview asset serving by SyMind · Pull Request #7738 · TanStack/router

SyMind · 2026-07-03T04:05:51Z

Upgrade @rsbuild/core for the RSC rsbuild e2e fixture to 2.1.2.
Add an rsbuild preview e2e mode for e2e/react-start/rsc-rsbuild.
Add preview-only coverage to verify SSR RSC client assets are served correctly by rsbuild preview.

Summary by CodeRabbit

New Features
- Added a new preview mode for the RSC rsbuild-based React starter, alongside the existing SSR flow.
Bug Fixes
- Updated the build tool (@rsbuild/core) to ^2.1.2 across multiple starters, examples, benchmarks, and end-to-end setups for consistency and compatibility.
Tests
- Updated the Playwright e2e setup to automatically start the correct server command based on the selected preview mode.

coderabbitai · 2026-07-03T04:06:36Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1f5e79b6-f8b8-44dc-8285-1b195671ac5f

📥 Commits

Reviewing files that changed from the base of the PR and between f516168 and 145386f.

⛔ Files ignored due to path filters (1)

pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (6)

examples/react/quickstart-rspack-file-based/package.json
examples/solid/quickstart-rspack-file-based/package.json
packages/react-start/package.json
packages/solid-start/package.json
packages/start-plugin-core/package.json
packages/vue-start/package.json

✅ Files skipped from review due to trivial changes (1)

packages/solid-start/package.json

🚧 Files skipped from review as they are similar to previous changes (5)

examples/solid/quickstart-rspack-file-based/package.json
packages/vue-start/package.json
examples/react/quickstart-rspack-file-based/package.json
packages/start-plugin-core/package.json
packages/react-start/package.json

📝 Walkthrough

Walkthrough

This PR updates @rsbuild/core to ^2.1.2 across workspace package manifests and adds preview-mode support for the e2e/react-start/rsc-rsbuild Playwright setup.

Changes

rsbuild/core bump and rsc preview mode

Layer / File(s)	Summary
rsc-rsbuild preview mode and Playwright config `e2e/react-start/rsc-rsbuild/package.json`, `e2e/react-start/rsc-rsbuild/playwright.config.ts`	Adds a `preview` script, adds a `preview` Playwright mode entry, and switches the web server command between `pnpm preview --port` and `pnpm start` based on `MODE`.
`@rsbuild/core` version bumps across package.json files `benchmarks/bundle-size/package.json`, `e2e/react-router//package.json`, `e2e/react-start//package.json`, `e2e/solid-router//package.json`, `e2e/solid-start//package.json`, `e2e/vue-router//package.json`, `e2e/vue-start/basic/package.json`, `examples/react/quickstart-rspack-file-based/package.json`, `examples/solid/quickstart-rspack-file-based/package.json`, `packages//package.json`	Updates `@rsbuild/core` from `^2.0.11` or `^2.0.8` to `^2.1.2` in the listed manifests.

Estimated code review effort: 2 (Simple) | ~10 minutes

Sequence Diagram(s)

sequenceDiagram
  participant Playwright as Playwright runner
  participant Config as playwright.config.ts
  participant Env as process.env.MODE
  participant WebServer as webServer command

  Playwright->>Config: load config
  Config->>Env: read MODE, default 'ssr'
  Config->>WebServer: choose pnpm preview or pnpm start
  Config->>WebServer: set env MODE

Possibly related issues

TanStack/router-monorepo#1: Tracks the same workspace-wide @rsbuild/core version upgrade across package manifests.

Possibly related PRs

TanStack/router#7245: Also updates @rsbuild/core version ranges across the repository’s package.json files.
TanStack/router#7509: Related to the e2e/react-start/rsc-rsbuild RSBuild/RSC integration and Playwright flow.

Suggested labels: package: react-start, package: solid-start, package: vue-start

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title matches the main change: upgrading rsbuild to support RSC preview asset serving.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

…build-preview # Conflicts: # pnpm-lock.yaml

socket-security · 2026-07-03T04:14:53Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	@rsbuild/core@2.1.2

View full report

socket-security · 2026-07-03T04:14:54Z

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action	Severity	Alert (click "▶" to expand/collapse)
Warn		Obfuscated code: npm `@emnapi/runtime` is 90.0% likely obfuscated Confidence: 0.90 Location: Package overview From: pnpm-lock.yaml → `npm/nitro@3.0.1-alpha.2` → `npm/@rsbuild/plugin-vue@1.2.7` → `npm/nitro@3.0.260311-beta` → `npm/wrangler@4.75.0` → `npm/@cloudflare/vite-plugin@1.29.1` → `npm/@rsbuild/plugin-react@2.0.0` → `npm/@rsbuild/core@2.1.2` → `npm/@swc-node/register@1.11.1` → `npm/@emnapi/runtime@1.11.1` ℹ Read more on: This package \| This alert \| What is obfuscated code? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at `support@socket.dev`. Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment `@SocketSecurity ignore npm/@emnapi/runtime@1.11.1`. You can also ignore all packages with `@SocketSecurity ignore-all`. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

nx-cloud · 2026-07-08T21:10:21Z

View your CI Pipeline Execution ↗ for commit 145386f

Command	Status	Duration	Result
`nx affected --targets=test:eslint,test:unit,tes...`	❌ Failed	14m 7s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	1m 47s	View ↗

☁️ Nx Cloud last updated this comment at 2026-07-08 21:25:41 UTC

pkg-pr-new · 2026-07-08T21:14:15Z

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7738

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7738

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7738

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7738

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7738

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7738

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7738

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7738

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7738

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7738

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7738

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7738

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7738

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7738

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7738

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7738

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7738

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7738

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7738

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7738

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7738

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7738

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7738

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7738

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7738

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7738

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7738

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7738

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7738

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7738

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7738

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7738

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7738

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7738

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7738

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7738

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7738

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7738

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7738

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7738

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7738

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7738

commit: 145386f

codspeed-hq · 2026-07-08T21:25:48Z

Merging this PR will not alter performance

✅ 96 untouched benchmarks
🗄️ 48 archived benchmarks run¹

_{Comparing SyMind:fix-rsbuild-preview (145386f) with main (a6337fb)}

48 benchmarks were run, but are now archived. If they were deleted in another branch, consider rebasing to remove them from the report. Instead if they were added back, click here to restore them. ↩

nx-cloud

Nx Cloud has identified a possible root cause for your failed CI:

This CI failure appears to be related to the environment or external dependencies rather than your code changes.

No code changes were suggested for this issue.

You can trigger a rerun by pushing an empty commit:

git commit --allow-empty -m "chore: trigger rerun"
git push

View detailed reasoning on Nx Cloud ↗

🔔 Heads up, your workspace has pending recommendations ↗ to auto-apply fixes for similar failures.

_{🎓 Learn more about Self-Healing CI on nx.dev}

fix(start): upgrade rsbuild for RSC preview asset serving

f516168

Merge branch 'main' of https://github.com/TanStack/router into fix-rs…

145386f

…build-preview # Conflicts: # pnpm-lock.yaml

nx-cloud Bot reviewed Jul 8, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(start): upgrade rsbuild for RSC preview asset serving#7738

fix(start): upgrade rsbuild for RSC preview asset serving#7738
SyMind wants to merge 2 commits into
TanStack:mainfrom
SyMind:fix-rsbuild-preview

SyMind commented Jul 3, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jul 3, 2026 •

edited

Loading

Walkthrough

Changes

Sequence Diagram(s)

Uh oh!

socket-security Bot commented Jul 3, 2026

Uh oh!

socket-security Bot commented Jul 3, 2026

Uh oh!

nx-cloud Bot commented Jul 8, 2026 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented Jul 8, 2026

Uh oh!

codspeed-hq Bot commented Jul 8, 2026

Uh oh!

nx-cloud Bot left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Uh oh!

Conversation

SyMind commented Jul 3, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jul 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Uh oh!

socket-security Bot commented Jul 3, 2026

Uh oh!

socket-security Bot commented Jul 3, 2026

Uh oh!

nx-cloud Bot commented Jul 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new Bot commented Jul 8, 2026

Uh oh!

codspeed-hq Bot commented Jul 8, 2026

Merging this PR will not alter performance

Footnotes

Uh oh!

nx-cloud Bot left a comment

Choose a reason for hiding this comment

Nx Cloud has identified a possible root cause for your failed CI:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

SyMind commented Jul 3, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 3, 2026 •

edited

Loading

nx-cloud Bot commented Jul 8, 2026 •

edited

Loading