fix: revert plugin changes, allow createMiddleware self compilation, fix HMR tests#7396
Open
Sheraff wants to merge 3 commits into
Open
fix: revert plugin changes, allow createMiddleware self compilation, fix HMR tests#7396Sheraff wants to merge 3 commits into
Sheraff wants to merge 3 commits into
Conversation
Contributor
|
View your CI Pipeline Execution ↗ for commit 2bd877c
☁️ Nx Cloud last updated this comment at |
Contributor
🚀 Changeset Version Preview42 package(s) bumped directly, 0 bumped as dependents. 🟨 Minor bumps
|
Contributor
Bundle Size Benchmarks
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better. |
![nx-cloud[bot]](https://avatars.githubusercontent.com/in/80458?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Important
At least one additional CI pipeline execution has run since the conclusion below was written and it may no longer be applicable.
Nx Cloud is proposing a fix for your failed CI:
We fixed two ESLint failures in @tanstack/start-client-core: the unnecessary type assertion on ctx in createCsrfMiddleware.ts (introduced when the parameter was widened to any) was removed, and the import order in hydrateStart.ts was corrected so that regular and relative imports precede the #-prefixed internal module imports. These changes bring the package into compliance with the project's no-unnecessary-type-assertion and import/order lint rules without altering any runtime behaviour.
Warning
❌ We could not verify this fix.
Suggested Fix changes
diff --git a/packages/start-client-core/src/client/hydrateStart.ts b/packages/start-client-core/src/client/hydrateStart.ts
index 206b7050..5ac46558 100644
--- a/packages/start-client-core/src/client/hydrateStart.ts
+++ b/packages/start-client-core/src/client/hydrateStart.ts
@@ -1,4 +1,7 @@
import { hydrate } from '@tanstack/router-core/ssr/client'
+import { ServerFunctionSerializationAdapter } from './ServerFunctionSerializationAdapter'
+import type { AnyRouter, AnySerializationAdapter } from '@tanstack/router-core'
+import type { AnyStartInstanceOptions } from '../createStart'
import { startInstance } from '#tanstack-start-entry'
import {
@@ -6,9 +9,6 @@ import {
pluginSerializationAdapters,
} from '#tanstack-start-plugin-adapters'
import { getRouter } from '#tanstack-router-entry'
-import { ServerFunctionSerializationAdapter } from './ServerFunctionSerializationAdapter'
-import type { AnyRouter, AnySerializationAdapter } from '@tanstack/router-core'
-import type { AnyStartInstanceOptions } from '../createStart'
export async function hydrateStart(): Promise<AnyRouter> {
const router = await getRouter()
diff --git a/packages/start-client-core/src/createCsrfMiddleware.ts b/packages/start-client-core/src/createCsrfMiddleware.ts
index 8bc4c90a..9c6864a1 100644
--- a/packages/start-client-core/src/createCsrfMiddleware.ts
+++ b/packages/start-client-core/src/createCsrfMiddleware.ts
@@ -78,7 +78,7 @@ type CreateCsrfMiddleware = <TRegister, TMiddlewares>(
const innerCreateCsrfMiddleware = ((opts: any = {}) => {
const middleware = createMiddleware().server(async (ctx: any) => {
- const csrfCtx = ctx as RequestServerOptions<any, any> & typeof ctx
+ const csrfCtx = ctx
if (opts.filter && !(await opts.filter(csrfCtx))) {
return ctx.next()
Or Apply changes locally with:
npx nx-cloud apply-locally 85j2-RH3a
Apply fix locally with your editor ↗ View interactive diff ↗
🎓 Learn more about Self-Healing CI on nx.dev
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.