Skip to content

test: split React Start basic e2e projects by mode#7047

Closed
beaussan wants to merge 4 commits intoTanStack:mainfrom
beaussan:split-tests-again
Closed

test: split React Start basic e2e projects by mode#7047
beaussan wants to merge 4 commits intoTanStack:mainfrom
beaussan:split-tests-again

Conversation

@beaussan
Copy link
Copy Markdown
Contributor

Summary

  • split e2e/react-start/basic into dedicated SSR, SPA, prerender, and preview Nx/pnpm projects
  • symlink the shared src, public, and tests directories into the new mode-specific projects while keeping per-project configs local
  • make the shared test helpers derive the active package name from process.cwd() so each project gets isolated ports and dummy-server state

Notes

  • did not run the split suites locally; pushing first so CI can validate the new project layout and wiring

Split the basic React Start e2e suite into dedicated SSR, SPA, prerender, and preview projects so CI can run each mode independently. Keep the shared specs symlinked while deriving package-specific ports from the active project root.
@nx-cloud
Copy link
Copy Markdown

nx-cloud bot commented Mar 26, 2026

View your CI Pipeline Execution ↗ for commit 893dc18

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 12m 33s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1m 58s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-26 23:22:28 UTC

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 26, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 619c6305-a7fa-47aa-89e3-31ddcb4a81f0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Mar 26, 2026

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@7047

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@7047

@tanstack/history

npm i https://pkg.pr.new/TanStack/router/@tanstack/history@7047

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/nitro-v2-vite-plugin@7047

@tanstack/react-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@7047

@tanstack/react-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@7047

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-ssr-query@7047

@tanstack/react-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@7047

@tanstack/react-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@7047

@tanstack/react-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@7047

@tanstack/router-cli

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@7047

@tanstack/router-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@7047

@tanstack/router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@7047

@tanstack/router-devtools-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@7047

@tanstack/router-generator

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@7047

@tanstack/router-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@7047

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-ssr-query-core@7047

@tanstack/router-utils

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@7047

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@7047

@tanstack/solid-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@7047

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@7047

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-ssr-query@7047

@tanstack/solid-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@7047

@tanstack/solid-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@7047

@tanstack/solid-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@7047

@tanstack/start-client-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@7047

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-fn-stubs@7047

@tanstack/start-plugin-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-plugin-core@7047

@tanstack/start-server-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@7047

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-static-server-functions@7047

@tanstack/start-storage-context

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-storage-context@7047

@tanstack/valibot-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@7047

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@7047

@tanstack/vue-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-router@7047

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-router-devtools@7047

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-router-ssr-query@7047

@tanstack/vue-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-start@7047

@tanstack/vue-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-start-client@7047

@tanstack/vue-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/vue-start-server@7047

@tanstack/zod-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@7047

commit: 893dc18

Keep the split projects' default build targets on the normal SSR build path so Nx build does not prerender error routes during affected runs. Give each split project its own generated route tree file and wait for the dummy server before prerender builds so the shared tests and external data fetches remain stable.
@beaussan beaussan closed this Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant