build: update to vite-config 0.5.x (rolldown)#6926
Conversation
🦋 Changeset detectedLatest commit: 2895046 The changes in this PR will be included in the next version bump. This PR includes changesets to release 40 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughDependency and build-config bumps (TanStack packages, Vite, vite-plugin-dts), Vite config key rename from Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 2895046
☁️ Nx Cloud last updated this comment at |
Bundle Size Benchmarks
Trend sparkline is historical gzip bytes ending with this PR measurement; lower is better. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.changeset/soft-ways-run.md:
- Line 44: The changeset message contains a typo: replace "rooldown" with
"rolldown" in the changeset entry that reads "build: update to vite-config 5.x
(rooldown)" inside .changeset/soft-ways-run.md so the message becomes "build:
update to vite-config 5.x (rolldown)"; ensure the file is saved with the
corrected word.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 9609b75e-843b-4e28-a95d-10e39ec846ba
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (8)
.changeset/soft-ways-run.mdpackage.jsonpackages/router-devtools-core/vite.config.tspackages/router-plugin/src/core/code-splitter/compilers.tspackages/router-plugin/src/core/route-autoimport-plugin.tspackages/solid-router/src/useBlocker.tsxpatches/@tanstack__vite-config@0.4.3.patchpatches/@tanstack__vite-config@0.5.1.patch
💤 Files with no reviewable changes (1)
- patches/@tanstack__vite-config@0.4.3.patch
|
Should we worry that this has a negative impact on both bundle size and client-side navigation? I haven't had the chance to make this same migration at work, so I don't know if this is expected or not. But i'm worried lol |
|
@Sheraff I think we absolutely should worry about that. Will set this PR to draft until we understand it better. |
|
Re-running locally, i can't verify a regression, it appear to be within noise. How do we re-run the CodSpeed ? The increase size in bundle is because of how rolldown treat CJS interop ( and react still being CJS-only, which comes at a cost ) |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
package.json (1)
95-96: Benchmark packages pinned to Vite 7 while rest of workspace uses Vite 8.Pinning
@benchmarks/bundle-sizeand@benchmarks/client-navto Vite 7.3.1 isolates benchmark results from the Vite 8 upgrade, which helps establish a consistent comparison baseline. However, this means benchmarks won't reflect the actual production build behavior with Vite 8.Is this intended as a temporary measure until the Rolldown bundle size investigation (mentioned in PR comments) is resolved, or is there a plan to update benchmarks to Vite 8 separately?
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@package.json` around lines 95 - 96, The benchmark packages "@benchmarks/bundle-size" and "@benchmarks/client-nav" are pinned to Vite 7.3.1 while the rest of the workspace uses Vite 8; either align these entries with the workspace Vite (update the versions to the Vite 8 range used elsewhere) or explicitly document the temporary override: add a clear comment in package.json (or move the pin into an overrides/notes section) explaining this is intentional for stable benchmark baselines and include the issue/PR reference for the Rolldown investigation so reviewers know when to remove or update the pin; update the version string for "@benchmarks/bundle-size>vite" and "@benchmarks/client-nav>vite" accordingly or add the comment next to those keys.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@package.json`:
- Line 56: The package vite-plugin-dts@4.2.3 is not guaranteed to work with Vite
8; either verify it functions under Vite 8 or migrate to unplugin-dts: in
package.json replace the vite-plugin-dts dependency with unplugin-dts (or add
it), update the Vite config where vite-plugin-dts is imported/used (search for
vite-plugin-dts in the repo) to use the unplugin-dts API (import from
'unplugin-dts/vite' and adjust options to match its config), and remove any
custom patch file that attempted to tweak module resolution so the canonical
plugin handles Vite 8 behavior; run a full dev build and type-declaration
generation to confirm compatibility and update package.json accordingly.
---
Nitpick comments:
In `@package.json`:
- Around line 95-96: The benchmark packages "@benchmarks/bundle-size" and
"@benchmarks/client-nav" are pinned to Vite 7.3.1 while the rest of the
workspace uses Vite 8; either align these entries with the workspace Vite
(update the versions to the Vite 8 range used elsewhere) or explicitly document
the temporary override: add a clear comment in package.json (or move the pin
into an overrides/notes section) explaining this is intentional for stable
benchmark baselines and include the issue/PR reference for the Rolldown
investigation so reviewers know when to remove or update the pin; update the
version string for "@benchmarks/bundle-size>vite" and
"@benchmarks/client-nav>vite" accordingly or add the comment next to those keys.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 1667510b-a076-4291-8fe8-3b2dd7b8c74d
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (1)
package.json
2 participants
Patched similarly to:
This upgrades the workspace build environment from rollup to rolldown.
Summary by CodeRabbit