WIP: Solid query main merge#10953
Conversation
… examples (TanStack#10553) fix(docs): correct import casing in no-unstable-deps examples
* feat(core): callback for retryOnMount * ci: apply automated fixes * fix: vue --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
ci: changeset release Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
ci: changeset release Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…omise' and 'skipToken' (TanStack#10527) * test(query-core/utils): add tests for 'ensureQueryFn' initialPromise fallback and skipToken handling * test(query-core/utils): use typed QueryFunctionContext in ensureQueryFn tests Replace the `(resolved as unknown as () => Promise<...>)()` double-cast with `resolved(context)` using a shared `QueryFunctionContext` fixture. Per review suggestions on TanStack#10527. --------- Co-authored-by: Wonsuk Choi <sukvvon@gmail.com>
…eject' tests to '@component' + 'render' pattern (TanStack#10572) * test(angular-query-experimental/injectQuery): switch 'success' and 'reject' tests to '@component' + 'render' pattern * ci: apply automated fixes --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
* fix: preserve infinite query behavior during SSR hydration (TanStack#8825) * chore: add changeset for TanStack#8825 * refactor: apply review feedback - Remove isRejectedThenable check - Inline behavior assignment * refactor: remove unnecessary `any` type assertions * refactor: store query type in Query instead of injecting behavior - Add a type field to Query, set from the _type marker - In Query.fetch(), apply infiniteQueryBehavior automatically when type === 'infiniteQuery' - Remove direct behavior injection from infiniteQueryObserver, fetchInfiniteQuery, ensureInfiniteQueryData, and hydrate() - In hydrate(), pass the _type marker instead of behavior to fix a regression where user-provided hydrate defaultOptions.queries.behavior could be overwritten - Add regression tests for the SSR -> dehydrate -> hydrate -> refetch flow * ci: apply automated fixes * ref: use optional type: 'infinite' everywhere * fix: don't send full queries into queryClient methods * fix: let's stick with queryType as the public name * fix: test -> it --------- Co-authored-by: kimchosule <kimchosule1@bizbee.co.kr> Co-authored-by: Dominik Dorfmeister 🔮 <office@dorfmeister.cc> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
…k#10510) * fix(query-core): stop wrapping persister generics in NoInfer The `persister` field on QueryOptions was typed as `QueryPersister<NoInfer<TQueryFnData>, NoInfer<TQueryKey>, NoInfer<TPageParam>>` so persister could not contribute to TQueryFnData inference. When the companion queryFn declared a parameter (e.g. `(_context) => 'test'`), TypeScript failed to infer TQueryFnData from its return and defaulted to `unknown`, causing a spurious overload mismatch against a concretely-typed persister (fixes TanStack#7842). Removing the NoInfer wrappers lets persister participate in inference. Genuine type conflicts between persister and queryFn still surface as errors (covered by a new negative type test in queryOptions.test-d.tsx). Co-Authored-By: Claude <noreply@anthropic.com> * test(react-query): wrap negative type tests in assertType Addresses CodeRabbit nitpick: vitest/expect-expect flagged the genuine-conflict test as having no assertions. Wrap both calls in assertType() so the linter sees an explicit assertion while the `@ts-expect-error` directives continue to enforce the type mismatch. Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Dominik Dorfmeister 🔮 <office@dorfmeister.cc>
ci: changeset release Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* useSuspenseQueries combine * useSuspenseQueries combine * ci: apply automated fixes * fix: stale data * ci: apply automated fixes (attempt 3/3) --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
ci: changeset release Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
TanStack#10118) * fix(devtools): change onClose callback type from () => unknown to () => void * Fix onClose callback type in devtools Updated onClose callback type in devtools to improve type safety. * chore(changeset): fixed truncated changeset description --------- Co-authored-by: Dominik Dorfmeister <office@dorfmeister.cc>
ci: changeset release Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…r fetchPage cancellation (TanStack#10476) * fix: propagate AbortSignal reason when cancelling infinite query fetchPage (Closes TanStack#10475) Signed-off-by: Cocoon-Break <54054995+kuishou68@users.noreply.github.com> * add a test --------- Signed-off-by: Cocoon-Break <54054995+kuishou68@users.noreply.github.com> Co-authored-by: Dominik Dorfmeister 🔮 <office@dorfmeister.cc>
ci: changeset release Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ror state when 'queryFn' rejects (TanStack#10585)
…ption transforming 'queryFn' data (TanStack#10586)
…erData' lifecycle (TanStack#10587)
…test already covered by 'should reject and update signal' (TanStack#10588)
…to '@component' + 'render' pattern (TanStack#10589)
…t to '@component' + 'render' pattern (TanStack#10590)
…Async' resolving with 'mutationFn' return value (TanStack#10591)
…tively reflecting changes to the provided signal (TanStack#10596)
…ate when one of the queries rejects (TanStack#10597)
…lving 'provideIsRestoring' value with 'injector' option (TanStack#10599)
…'beforeEach' and rename injected/spied clients (TanStack#10919)
… runs under fake timers (TanStack#10920) * test(*): move 'vi.useRealTimers' to the end of 'afterEach' so cleanup runs under fake timers * test(*): move 'vi.useRealTimers' to the end of 'afterEach' in persist-client and devtools suites * test(svelte-query/createQueries): move 'vi.useRealTimers' to the end of 'afterEach'
… with 'toHaveBeenCalledWith' and 'toHaveBeenCalled' (TanStack#10935)
…mes' with 'toHaveBeenCalledTimes' (TanStack#10940)
… with 'toHaveBeenCalledWith' (TanStack#10941)
…satisfy 'sort-imports' (TanStack#10946)
…tation' into separate success and error tests (TanStack#10947)
…nal logic based on mutate success or failure' into separate success and error tests (TanStack#10948)
…nto separate success and error tests (TanStack#10949)
…QueryClientProvider' wrapping in tests (TanStack#10950)
…storing period when 'isRestoring' is true (TanStack#10951)
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit f87aa3c
☁️ Nx Cloud last updated this comment at |
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
More templates
@tanstack/angular-query-experimental
@tanstack/eslint-plugin-query
@tanstack/lit-query
@tanstack/preact-query
@tanstack/preact-query-devtools
@tanstack/preact-query-persist-client
@tanstack/query-async-storage-persister
@tanstack/query-broadcast-client-experimental
@tanstack/query-core
@tanstack/query-devtools
@tanstack/query-persist-client-core
@tanstack/query-sync-storage-persister
@tanstack/react-query
@tanstack/react-query-devtools
@tanstack/react-query-next-experimental
@tanstack/react-query-persist-client
@tanstack/solid-query
@tanstack/solid-query-devtools
@tanstack/solid-query-persist-client
@tanstack/svelte-query
@tanstack/svelte-query-devtools
@tanstack/svelte-query-persist-client
@tanstack/vue-query
@tanstack/vue-query-devtools
commit: |
…fix Solid 2.0 test usages
useMutation's observer subscriber wrote to the store directly, so calling
mutate() synchronously from an owned scope (during render or inside an
effect) triggered the subscriber synchronously and threw
[SIGNAL_WRITE_IN_OWNED_SCOPE], silently turning the mutation into an error.
Wrap setState in runWithOwner(null, ...) to escape the owner, matching
useBaseQuery/useQueries.
Also update tests for Solid 2.0 APIs:
- useMutation: replace invalid single-arg createEffect with createTrackedEffect
- useQuery: Errored fallback receives an error accessor, use err()
- useInfiniteQuery: add keyed={false} so the outer For yields an accessor
- useQueries: use IsRestoringContext as a component instead of the
non-existent IsRestoringProvider
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…for solid-query packages knip now resolves @solidjs/web usage on its own, so the ignore entries for packages/solid-query and packages/solid-query-persist-client are flagged as unnecessary config hints. Drop them to satisfy --treat-config-hints-as-errors. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…) in tests The Solid 2.0 migration mounted the devtools instance via queueMicrotask and forwarded props via deferred createEffect, so the synchronous test assertions (forwarding + unmount-on-cleanup) never saw the calls. - Replace the queueMicrotask mount + onCleanup unmount with onSettled, the 2.0 lifecycle primitive that replaces onMount + onCleanup (setup runs after the first stable render, returned cleanup runs on disposal). devtools.mount renders a nested Solid app (creating reactive primitives), which is forbidden inside an owned scope, so escape the owner with runWithOwner(null). - In the tests, call flush() after render() (and before unmount) to run the deferred effects and onSettled synchronously, matching the existing synchronous assertions. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
20 participants
🎯 Changes
✅ Checklist
pnpm run test:pr.🚀 Release Impact