fix(solid-query): skip reconcile when data reference is unchanged#10598
Open
ousamabenyounes wants to merge 2 commits intoTanStack:mainfrom
Open
fix(solid-query): skip reconcile when data reference is unchanged#10598ousamabenyounes wants to merge 2 commits intoTanStack:mainfrom
ousamabenyounes wants to merge 2 commits intoTanStack:mainfrom
Conversation
Previously, the reconcile path in useBaseQuery would invoke the user's reconcile callback (or the structural reconcile from solid-js/store) multiple times per logical query update — once for fetching=true transitions where the data reference had not changed, and again when the actual data resolved. With user-provided reconcile functions, this showed up as oldData === newData calls. Short-circuit reconcileFn when store.data === result.data; the rest of the result still flows through setState so isFetching/status updates keep working. Closes TanStack#8873
Contributor
📝 WalkthroughWalkthroughA patch release for Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 06b14a6
☁️ Nx Cloud last updated this comment at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
useBaseQuery, the reconcile path could fire multiple times per logical query update — once for fetching state transitions whereresult.datawas the same reference as the current store data, and again when the actual data resolved. With a user-providedreconcilecallback, this surfaced asoldData === newDatainvocations and 2-4 reconcile calls per request.This change short-circuits
reconcileFnwhenstore.data === result.data. The rest of the result still flows throughsetStatesoisFetching/statuskeep updating reactively.Closes #8873
Test plan
useQuery.test.tsx > should not call user-provided reconcile function when result.data reference is unchanged (#8873)pnpm exec nx run @tanstack/solid-query:test:lib— 310 passedpnpm exec nx run @tanstack/solid-query:test:types— passedpnpm exec nx run @tanstack/solid-query:test:eslint— passedGenerated by Ora Studio / Vibe coded by ousamabenyounes
🤖 Generated with Claude Code
Summary by CodeRabbit
Generated by Ora Studio (with Claude Code)
Vibe coded by Ben Younes Ousama