fix CI workflow path drift in root automation#84
Conversation
|
📝 WalkthroughWalkthroughUpdated GitHub Actions: small changes to the PR workflow and removal of three separate workflows that handled skill staleness checks, skill validation, and automated feedback labeling. No source code or public API signatures were modified. (46 words) Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can use oxc to improve the quality of JavaScript and TypeScript code reviews.Add a configuration file to your project to customize how CodeRabbit runs oxc. |
commit: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/validate-skills.yml:
- Around line 3-7: The workflow currently invokes scripts/validate-skills.ts
with no arguments so the script defaults to scanning repository-root skills/
(which doesn't exist) and findSkillFiles() returns nothing; update the workflow
trigger invocation of scripts/validate-skills.ts to pass the correct directory
(the package directory being watched, e.g. "packages/intent/meta" or the exact
path your skill files live in) so validate-skills.ts scans the intended folder;
ensure the workflow command argument matches the directory structure used by
findSkillFiles() and keep the script invocation consistent with the on: paths.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: d50f7b4c-e17f-43fe-9266-9fc3bb415d7d
📒 Files selected for processing (3)
.github/workflows/pr.yml.github/workflows/skill-staleness-check.yml.github/workflows/validate-skills.yml
| on: | ||
| pull_request: | ||
| paths: | ||
| - 'packages/intent/meta/**' | ||
| - 'scripts/validate-skills.ts' |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify where SKILL.md files actually exist in the repository
echo "=== Searching for SKILL.md files ==="
fd -t f "SKILL.md" --exclude node_modules
echo ""
echo "=== Checking if skills/ directory exists at root ==="
if [ -d "skills" ]; then
echo "skills/ directory exists at root"
tree -L 3 skills 2>/dev/null || ls -la skills
else
echo "No skills/ directory at repository root"
fi
echo ""
echo "=== Checking packages/intent/meta/ structure ==="
if [ -d "packages/intent/meta" ]; then
echo "packages/intent/meta/ exists"
tree -L 3 packages/intent/meta 2>/dev/null || ls -la packages/intent/meta
else
echo "No packages/intent/meta/ directory"
fiRepository: TanStack/intent
Length of output: 945
🏁 Script executed:
cat scripts/validate-skills.tsRepository: TanStack/intent
Length of output: 5025
Validation script is silently skipped — pass the correct directory path.
The workflow triggers on packages/intent/meta/** changes but runs the validation script without any arguments. The script defaults to scanning skills/ at the repository root, which doesn't exist. Since the directory is missing, findSkillFiles() returns no results and the script exits successfully (exit code 0) with the message "No SKILL.md files found — nothing to validate" — making validation silently skip without error.
Pass the correct directory to the validation script:
Fix
- name: Run validation
- run: npx tsx scripts/validate-skills.ts
+ run: npx tsx scripts/validate-skills.ts packages/intent/meta🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.github/workflows/validate-skills.yml around lines 3 - 7, The workflow
currently invokes scripts/validate-skills.ts with no arguments so the script
defaults to scanning repository-root skills/ (which doesn't exist) and
findSkillFiles() returns nothing; update the workflow trigger invocation of
scripts/validate-skills.ts to pass the correct directory (the package directory
being watched, e.g. "packages/intent/meta" or the exact path your skill files
live in) so validate-skills.ts scans the intended folder; ensure the workflow
command argument matches the directory structure used by findSkillFiles() and
keep the script invocation consistent with the on: paths.
2 participants
Summary
README.mdusing the correct pathpkg-pr-newtemplate argument so preview publishing only targets existing packagesintentrepo setupSummary by CodeRabbit