Skip to content

Conversation

@crutchcorn
Copy link
Member

@crutchcorn crutchcorn commented Dec 1, 2025

Without introducing breaking changes this should fix a ton of issues with SSR

TODO

  • Write initial transform test for core
  • Test Start no JS SSR
  • Test Remix no JS SSR

@changeset-bot
Copy link

changeset-bot bot commented Dec 1, 2025

🦋 Changeset detected

Latest commit: 8c2b568

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nx-cloud
Copy link

nx-cloud bot commented Dec 1, 2025

View your CI Pipeline Execution ↗ for commit 8c2b568

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 1m 23s View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded 1s View ↗

☁️ Nx Cloud last updated this comment at 2026-02-13 03:39:40 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 1, 2025

More templates

@tanstack/angular-form

npm i https://pkg.pr.new/@tanstack/angular-form@1890

@tanstack/form-core

npm i https://pkg.pr.new/@tanstack/form-core@1890

@tanstack/form-devtools

npm i https://pkg.pr.new/@tanstack/form-devtools@1890

@tanstack/lit-form

npm i https://pkg.pr.new/@tanstack/lit-form@1890

@tanstack/react-form

npm i https://pkg.pr.new/@tanstack/react-form@1890

@tanstack/react-form-devtools

npm i https://pkg.pr.new/@tanstack/react-form-devtools@1890

@tanstack/react-form-nextjs

npm i https://pkg.pr.new/@tanstack/react-form-nextjs@1890

@tanstack/react-form-remix

npm i https://pkg.pr.new/@tanstack/react-form-remix@1890

@tanstack/react-form-start

npm i https://pkg.pr.new/@tanstack/react-form-start@1890

@tanstack/solid-form

npm i https://pkg.pr.new/@tanstack/solid-form@1890

@tanstack/solid-form-devtools

npm i https://pkg.pr.new/@tanstack/solid-form-devtools@1890

@tanstack/svelte-form

npm i https://pkg.pr.new/@tanstack/svelte-form@1890

@tanstack/vue-form

npm i https://pkg.pr.new/@tanstack/vue-form@1890

commit: 8c2b568

@crutchcorn
Copy link
Member Author

crutchcorn commented Dec 1, 2025

List of related issues:

#1611

#1609

#1571

#1260

#1944

@crutchcorn crutchcorn changed the title [WIP] Fix issues with SSR Fix issues with SSR Jan 28, 2026
@sentry
Copy link

sentry bot commented Jan 28, 2026

Codecov Report

❌ Patch coverage is 78.94737% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.93%. Comparing base (6892ed0) to head (8c2b568).
⚠️ Report is 134 commits behind head on main.

Files with missing lines Patch % Lines
packages/form-core/src/utils.ts 60.00% 10 Missing ⚠️
packages/form-core/src/transform.ts 89.47% 2 Missing ⚠️
packages/form-core/src/FormApi.ts 95.45% 1 Missing ⚠️
packages/react-form-nextjs/src/useTransform.ts 0.00% 1 Missing ⚠️
packages/react-form-remix/src/useTransform.ts 0.00% 1 Missing ⚠️
packages/react-form-start/src/useTransform.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1890      +/-   ##
==========================================
- Coverage   90.35%   89.93%   -0.43%     
==========================================
  Files          38       49      +11     
  Lines        1752     2006     +254     
  Branches      444      507      +63     
==========================================
+ Hits         1583     1804     +221     
- Misses        149      181      +32     
- Partials       20       21       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@crutchcorn crutchcorn changed the title Fix issues with SSR [WIP] Fix issues with SSR Jan 28, 2026
@crutchcorn crutchcorn marked this pull request as draft January 28, 2026 02:48
@crutchcorn crutchcorn changed the title [WIP] Fix issues with SSR Fix issues with SSR Jan 30, 2026
@crutchcorn crutchcorn marked this pull request as ready for review January 30, 2026 03:30
Copy link
Contributor

@LeCarbonator LeCarbonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just some small nitpicks, but they're not blocking as far as I'm concerned.

crutchcorn and others added 3 commits February 12, 2026 19:32
Co-authored-by: LeCarbonator <18158911+LeCarbonator@users.noreply.github.com>
Things should now work as-expected in many more scenarios than before.
@crutchcorn crutchcorn merged commit 72d970a into main Feb 13, 2026
6 of 7 checks passed
@crutchcorn crutchcorn deleted the fix-ssr-issue branch February 13, 2026 03:40
@github-actions github-actions bot mentioned this pull request Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants