-
-
Notifications
You must be signed in to change notification settings - Fork 587
Fix issues with SSR #1890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issues with SSR #1890
Conversation
🦋 Changeset detectedLatest commit: 8c2b568 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
View your CI Pipeline Execution ↗ for commit 8c2b568
☁️ Nx Cloud last updated this comment at |
# Conflicts: # examples/react/next-server-actions/package.json
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1890 +/- ##
==========================================
- Coverage 90.35% 89.93% -0.43%
==========================================
Files 38 49 +11
Lines 1752 2006 +254
Branches 444 507 +63
==========================================
+ Hits 1583 1804 +221
- Misses 149 181 +32
- Partials 20 21 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
# Conflicts: # packages/react-form-start/src/createServerValidate.tsx
LeCarbonator
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just some small nitpicks, but they're not blocking as far as I'm concerned.
Co-authored-by: LeCarbonator <18158911+LeCarbonator@users.noreply.github.com>
Things should now work as-expected in many more scenarios than before.
Without introducing breaking changes this should fix a ton of issues with SSR
TODO
transformtest for core