fix(db): includes orderBy ignored after optimistic update on child collection#1496
Open
comet08 wants to merge 1 commit intoTanStack:mainfrom
Open
fix(db): includes orderBy ignored after optimistic update on child collection#1496comet08 wants to merge 1 commit intoTanStack:mainfrom
comet08 wants to merge 1 commit intoTanStack:mainfrom
Conversation
…llection to avoid stale sort order Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1444
🎯 Changes
When a child collection item is updated, the D2 graph emits a
(-1, +1)pair. If the delete (-1) message arrives first, an accumulator entry is created with the oldorderByIndex. The subsequent insert (+1) message updatedvaluecorrectly but never updatedorderByIndex— so the child collection's comparator kept using the stale positional index.This caused incorrect sort order immediately after optimistic updates on child collections, with ordering only correcting itself after server confirmation.
The parent pipeline (
accumulateChanges) already handled this correctly. This fix applies the sameorderByIndexupdate logic to the child pipeline accumulator and the nested pipeline accumulator for consistency.✅ Checklist
pnpm test.🚀 Release Impact