fix: preview tab double-click detection and promotion#844
Open
fix: preview tab double-click detection and promotion#844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DoubleClickDetectorbounds check: walk up toNSTableRowViewinstead of checking tiny overlay text boundsasPreviewparameter toopenTableTabso double-click can force non-preview modeRoot Cause
The
SharedDoubleClickMonitordetectedclickCount == 2events correctly, but the bounds check failed because theSidebarDoubleClickViewoverlay was sized to the text label width (67-156px), not the full row width. Clicks in the right portion of the row fell outside the overlay bounds.Changes
DoubleClickDetector.swift: Walk up the view hierarchy to the nearestNSTableRowViewand check bounds against the full row, not the overlay.MainContentCoordinator+Navigation.swift: AddedasPreview: Bool? = nilparameter.nil= use setting (default),false= force permanent (double-click).MainSplitViewController.swift: Double-click handler passesasPreview: false.Test plan