feat: MCP three-tier query safety with server-side confirmation#839
Merged
feat: MCP three-tier query safety with server-side confirmation#839
Conversation
- Safe (SELECT/SHOW/EXPLAIN): executes immediately - Write (UPDATE/DELETE): forces native macOS confirmation dialog - Destructive (DROP/TRUNCATE): requires confirm_destructive_operation tool + native dialog - INSERT exempt from confirmation (additive, non-destructive) - CTE-prefixed writes (WITH...DELETE) properly detected - RETURNING clause routes to fetchRows for result rows - Multi-statement queries blocked via SQLStatementScanner - Server-side trust model: confirmation cannot be bypassed by MCP client
datlechin
force-pushed
the
feat/mcp-query-safety
branch
from
ab116d1 to
9bb4199
Compare
…ecurity details Also fix export_data tool description claiming XLSX support (not implemented).
…ed() copy in bridge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
confirm_destructive_operationtool with explicit confirmation phraseWITH...DELETE) properly detectedRETURNINGclause routes tofetchRowsso result rows are returnedSQLStatementScannerTest plan
;separated) is rejectedWITH...DELETE) is classified as write