Make the inspector actually resize freely#1679
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Sets the inspector pane's
maximumThicknesstoNSSplitViewItem.unspecifiedDimensionso it can be dragged to any width.Why
#1676 tried to free the inspector by deleting
maximumThickness = 400, but that made it worse. On macOS 14+,NSSplitViewItem(inspectorWithViewController:)defaults bothminimumThicknessandmaximumThicknessto 270 ("aren't resizable by default"). Removing the explicit 400 let the max fall back to that 270 default, somin == max == 270: zero divider travel, the inspector was pinned and could not resize at all.Setting
maximumThickness = unspecifiedDimensionremoves the hard drag stop entirely, which is the documented, necessary-and-sufficient change for unbounded drag width. The 270 minimum stays so the panel keeps a usable floor.Notes
recomputeWindowMinSize()only reads minimums, so the window min-size logic is unaffected.autosaveName("com.TablePro.mainSplit") persist the chosen width.Ref: https://developer.apple.com/documentation/appkit/nssplitviewitem/init(inspectorwithviewcontroller:)