Create KnowledgeBaseBuilder and extract settings from knowledge base class#24
Open
DaviddeBest-TNO wants to merge 14 commits into
Open
Create KnowledgeBaseBuilder and extract settings from knowledge base class#24DaviddeBest-TNO wants to merge 14 commits into
DaviddeBest-TNO wants to merge 14 commits into
Conversation
- Add KnowledgeBaseBuilder in src/knowledge_base_builder.py - KnowledgeBase.from_settings() now returns a KnowledgeBaseBuilder instead of a KnowledgeBase; KnowledgeBase has no _build_settings field - KnowledgeBaseBuilder.handler(name, func) attaches a handler to an ANSWER or REACT KI declared in settings - ASK and POST KIs are auto-registered from settings at builder.build() time - builder.build() raises ValueError if any ANSWER/REACT KI has no handler - Export KnowledgeBaseBuilder from src/__init__.py - Update test_configuration.py to use the builder pattern - Add tests/test_knowledge_base_builder.py with 12 new behaviour tests - Update CONTEXT.md to reflect new layout and builder API Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #23