Add desugaring required by Google IMA SDK#39
Merged
Conversation
OlegRyz
requested review from
adadukin-dolby,
ceyhun-o and
georgechoustoulakis
and removed request for
ceyhun-o
adadukin-dolby
approved these changes
Apr 20, 2026
adadukin-dolby
left a comment
adadukin-dolby
left a comment
There was a problem hiding this comment.
only a few minor comments, overall looks good to me
There was a problem hiding this comment.
Let's add a new line at the end of the file.
Can you, please, check other files as well as there are a few new files with missing new lines at the end of the file.
Contributor
Author
There was a problem hiding this comment.
Thanks, I added them to the files I edited
| ).ads( | ||
| TheoAdDescription( | ||
| networkCode = "network-code-here", | ||
| customAssetKey = "asset-key-here", |
There was a problem hiding this comment.
do we want to leave this as strings, or maybe leave unimplemented to fail the build?
Contributor
There was a problem hiding this comment.
we don't want the build to fail. these values are placeholders to show how a THEOads stream can be set on the player.
ceyhun-o
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting from 11.x we use Google IMA SDK 3.37+ which requires our users to enable desugaring.