Guide recipes use real template parameters + attribute-aware parameter listing#142
Open
zekelinAlex wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The guide tool plans component scaffolding by asking the model what commands to run, but the model doesn't know a template's parameters, so it made up names like FieldName that don't exist and the create call failed. This attaches the real parameter list to the recipe.
Сlose: #92
How GuideHandle worksr:
Сlose: #88
How ComponentParameterListCliCommand works:
1.The user runs txc workspace component parameter list pp-entity-attribute --param AttributeType=Text.
2. The command fetches the template's full parameter list via ListParametersForTemplateAsync
3. ParseParamValues turns the --param values into a dictionary
4. f at least one --param was given, FilterEnabled is called with the parameter list and that dictionary
5. For each parameter that has an isEnabled condition, method Evaluate runs; the parameter stays if it has no condition or the condition is true
6. The filtered list is printed, and each parameter also shows its appliesWhen / requiredWhen conditions