Provide an async implementation for the keystore#72
Draft
eikek wants to merge 1 commit into
Draft
Conversation
Wraps blocking calls in `tokio::task::spawn_blocking` to ensure they run on a dedicated thread pool. When instantiating the http-client, the access token is not read from the keystore at construction time, but on each request instead. This ensures the proper token on long lived instances. This is more a theoretical problem with the cli, but the code could be used as a library as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wraps blocking calls in
tokio::task::spawn_blockingto ensure they run on a dedicated thread pool.When instantiating the http-client, the access token is not read from the keystore at construction time, but on each request instead. This ensures the proper token on long lived instances. This is more a theoretical problem with the cli, but the code could be used as a library as well.