Draft
Conversation
Member
Author
|
Note: After I left this running overnight and then I came back the next day the mount is broken. But right after I created the mount restarting the daemon set had no effect on the mount and it kept working. But I suspect this is because the implementation I deployed is not complete. And potentially a remount or unmount/mount cycle was attempted and it failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a POC.
It needs more testing / work.
I think we can probably cut down on the number of things we mount from the host.
See the mount implementation for mount utils from k8s:
https://github.com/kubernetes/mount-utils/blob/v0.35.1/mount_linux.go#L221
They also use
systemd-run. I wonder if they expect thatsystemd-runwill be mounted from the host.Either way there is a test deployment in the
taskonamespace on the dev cluster. You can see the onlytest-podthere. It has the giab s3 bucket mounted at/giab. You can restart the daemon set on the right node and the mount will keep working.