Remove hardcoded CourtFormsOnline fallback; use proper global config appname, not app name#1049
Merged
Merged
Conversation
… appname, not app name
nonprofittechy
force-pushed
the
correct-brand-fallback
branch
from
f75e989 to
0d63ef9
Compare
BryceStevenWilley
approved these changes
May 13, 2026
Contributor
BryceStevenWilley
left a comment
BryceStevenWilley
left a comment
There was a problem hiding this comment.
Looks good to me, tried to think of a more generic term than docassemble but nothing really came to mind. Given it's the normal default for appname too, I think it's good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've kind of been polluting the brand "CourtFormsOnline" in the interview list on servers that aren't part of CourtFormsOnline because of two issues:
appnameconfig--we had a typoapp namewhich isn't normally defined in a Docassemble configappnameisn't defined was CourtFormsOnline. There's no good reason for that--we have 100% control over the servers where we want the interview list title to be CourtFormsOnline.This PR just corrects the typo and removes the default CourtFormsOnline language, which is really a specific brand name for apps.suffolklitlab.org only.