Conversation
This commit strips tag prefix before sorting semver tags and re-adds it to result.
rchl
reviewed
Feb 4, 2026
Comment on lines
+13
to
+22
| # find latest ref matching prefix | ||
| local ref=$( | ||
| echo "$refs" \ | ||
| | sed -E -n "s%.*refs/tags/${prefix-v?}([0-9]+\.[0-9]+\.[0-9]+)\$%\1%p" \ | ||
| | grep -v '\^{}$' \ | ||
| | sort -t. -k1,1nr -k2,2nr -k3,3nr \ | ||
| | head -n1 | ||
| ) | ||
| if [ -n "$ref" ]; then | ||
| echo "$prefix$ref" |
Member
There was a problem hiding this comment.
I think one case it doesn't handle is when no prefix is provided but tags start with v. Then $prefix will be an empty string and v won't be part of returned ref.
Member
There was a problem hiding this comment.
Also it seems like ${prefix-v?} will only fall back to v? when it's not set which I believe will never be true in this case. It doesn't fall back when $prefix is empty string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #279
This commit...
sort ...work as expected.