Fixes async expression compiler bugs and updates nugets#133
Merged
Fixes async expression compiler bugs and updates nugets#133
Conversation
… expand ExpressionRuntimeOptions - Fix #126: Add EnsureConvert helper to Transition base class that wraps value-type expressions in Convert() when assigning to reference-type variables (boxing). Applied in Transition.SetResult and FinalTransition.AddExpressions. - Add failing test for #123: IfThen with Return(label, value) in BlockAsync returns null instead of expected value. Root cause is in the lowering phase where Returns inside non-lowered conditionals are not converted to _finalResultVariable assignments. - Expand ExpressionRuntimeOptions with Optimize flag (default true) to conditionally skip StateOptimizer, and SourceHandler callback to capture the generated state machine expression for debugging. - Add .claude/ to .gitignore.
…urn gotos with assignments
7 tasks
bfarmer67
added a commit
that referenced
this pull request
Mar 1, 2026
* Fixes async expression compiler bugs and updates nugets (#133) * Fix value-type boxing in Transition (#126), add failing test for #123, expand ExpressionRuntimeOptions - Fix #126: Add EnsureConvert helper to Transition base class that wraps value-type expressions in Convert() when assigning to reference-type variables (boxing). Applied in Transition.SetResult and FinalTransition.AddExpressions. - Add failing test for #123: IfThen with Return(label, value) in BlockAsync returns null instead of expected value. Root cause is in the lowering phase where Returns inside non-lowered conditionals are not converted to _finalResultVariable assignments. - Expand ExpressionRuntimeOptions with Optimize flag (default true) to conditionally skip StateOptimizer, and SourceHandler callback to capture the generated state machine expression for debugging. * Change SourceHandler to Action<string> with UnsafeAccessor for DebugView, add tests * fix(expressions): Ensure Return gotos inside non-lowered expressions set final result * test(expressions): Add regression test for Return labels in async TryCatch * test(compiler): Add FastExpressionCompiler compatibility test for Return gotos with assignments * Update nugets and cleanup * chore(nbgv): set version via CI: 1.4.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses several issues in the async expression compiler, including a value-type boxing issue, incorrect handling of Return gotos in TryCatch blocks, and ensures final result assignment in non-lowered expressions. Also updates NuGet package versions.
Fixes #123Fixes #126Type of Change
Checklist