Skip to content

Fix broken external links found with automated link checking#424

Open
Copilot wants to merge 28 commits intomainfrom
copilot/scan-for-broken-links
Open

Fix broken external links found with automated link checking#424
Copilot wants to merge 28 commits intomainfrom
copilot/scan-for-broken-links

Conversation

Copy link
Contributor

Copilot AI commented Feb 5, 2026

Addresses broken external URLs across the documentation.

Broken link fixes (~150 files)

  • Broadcom TechDocs migrations: docs.pivotal.io and docs.vmware.com links updated to current techdocs.broadcom.com paths for Spring Cloud Services → Application Services, SSO, CredHub, MySQL, Postgres, RabbitMQ, Redis/Valkey, GemFire Native Client, Metric Registrar, Volume Services, CSB (AWS/Azure/GCP), Apps Manager
  • Microsoft: docs.microsoft.comlearn.microsoft.com, docs.asp.netlearn.microsoft.com, visualstudio.comvisualstudio.microsoft.com; reduced redirects where possible without forcing localization
  • Spring: projects.spring.io/spring-cloudspring.io/projects/spring-cloud-*; trailing slash fixes
  • GitHub repo moves: spring-cloud-samples/hystrix-dashboardNetflix-Skunkworks/hystrix-dashboard, cf-platform-eng/mssql-server-brokercloudfoundry-attic/mssql-server-broker, cloudfoundry-incubatorcloudfoundry
  • CredHub API: credhub-api.cfapps.iodocs.cloudfoundry.org/api/credhub/version/main/ with corrected anchors (#_overwriting_credential_values, #_permissions)
  • Discontinued services: Hystrix Dashboard marked as deprecated (no longer available), Wavefront trial references removed, dead pivotal.io/platform-acceleration-lab links removed
  • Naming: "PCF" → "Tanzu Platform", "TAS Apps Manager" → "Apps Manager", "TAS SSO" / "TAS Single-Sign-on" → "Single Sign-On", "Azure Open Service Broker" → "Open Service Broker for Azure"
  • Misc: RabbitMQ docs path updates, tanzu.vmware.com/gemfirevmware.com/products/..., tanzu.vmware.com/observabilitybroadcom.com/products/..., hhttps typo, start.steeltoe.io/api/config//api/uiconfig/

Also fixes root-relative markdown links that docfx does not see (inadvertently broken in #363)

Original prompt

This section details on the original issue you should resolve

<issue_title>Scan for broken links to external URLs</issue_title>
<issue_description>We should run a tool that recursively follows all the links and reports which ones are broken. And then correct or remove them.

For example, there are many links pointing to docs.pivotal.io, such as https://docs.pivotal.io/spring-cloud-services/1-5/common/circuit-breaker/, which today redirects to the generic Broadcom page at https://techdocs.broadcom.com/us/en/vmware-tanzu.html.</issue_description>

Comments on the Issue (you are @copilot in this section)

@bart-vmware Remaining _hard_ broken links after the fixes in #385 are listed in the table below. Note this does not include soft broken links, such as the one mentioned above.
URL Anchor Text Linked From
https://credhub-api.cfapps.io/ CredHub API [https...</comment_new>

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Scan for broken links to external URLs Add link checking and fix broken documentation references Feb 5, 2026
Copilot AI requested a review from TimHess February 5, 2026 15:10
@TimHess

This comment was marked as resolved.

@TimHess TimHess changed the base branch from main to copilot/setup-copilot-instructions February 19, 2026 21:10

This comment was marked as resolved.

@github-actions

This comment was marked as outdated.

This comment was marked as off-topic.

Copilot AI requested a review from TimHess February 19, 2026 21:38
TimHess

This comment was marked as resolved.

This comment was marked as resolved.

Copilot AI requested a review from TimHess February 19, 2026 22:13
@TimHess

This comment was marked as resolved.

This comment was marked as resolved.

Base automatically changed from copilot/setup-copilot-instructions to main February 20, 2026 19:11
Copilot AI changed the title Add link checking and fix broken documentation references Add link checking workflow and fix broken external URLs Feb 20, 2026
--verbose is needed to see redirect details
- locally:
  - set user-agent locally to avoid 403 on mysql links (doesn't seem to affect CI)
  - ignore build/docfx-net10-binaries (like playwright readme)
- longer host-request-interval and retry-wait-time
@TimHess TimHess force-pushed the copilot/scan-for-broken-links branch from 30baab7 to 18ceece Compare February 26, 2026 21:16
@TimHess TimHess changed the title Fix broken external links and add automated link checking Fix broken external links found with automated link checking Feb 26, 2026
@TimHess TimHess force-pushed the copilot/scan-for-broken-links branch from 18ceece to 4563611 Compare February 26, 2026 21:50
TimHess
TimHess previously approved these changes Feb 26, 2026
- since redirect fixes are already in place in other PR, change verbosity now
TimHess and others added 6 commits February 27, 2026 11:57
- also include a paste-able snippet to bust the cache for a given PR
- external links to
  - CredHub API, Spring AMQP, and Spring Cloud projects
  - Broadcom/Pivotal/samples/Microsoft
- CredHub/Samples/CircuitBreaker links
- Reduce external redirects
- Fix double 'the' in fileshares usage docs
- Disambiguate Redis/Valkey versions, clarify Thinktecture reference
- Fix 'n0t' typo in v3 fileshares docs
- TAS SSO→Single Sign-On

Co-authored-by: TimHess <3947063+TimHess@users.noreply.github.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
- redirect reductions for docs.microsoft.com and trailing slashes
- remove /en-US/ from mozilla links
@bart-vmware
Copy link
Member

Additional broken link, found in Blazor sources: https://store.education.pivotal.io/confirm-course?courseid=EDU-1180

@TimHess
Copy link
Member

TimHess commented Mar 2, 2026

Additional broken link, found in Blazor sources: https://store.education.pivotal.io/confirm-course?courseid=EDU-1180

That page wasn't linked anymore, analytics show no traffic in the last year, so I just removed it

Copy link
Member

@bart-vmware bart-vmware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed most of the changes. Most of docs/v2 is still pending.

TimHess and others added 2 commits March 2, 2026 14:39
Co-authored-by: Bart Koelman <104792814+bart-vmware@users.noreply.github.com>
- CredHub "on Tanzu Platform" links updated to Broadcom TechDocs (v2, v3)
- Hystrix flow chart anchor corrected from #collapser-flow to #flow-chart (v2, v3)
- NuGet profile URL corrected to SteeltoeOSS
- CosmosDB, MySQL, PostgreSQL v2/v3: restore original broker names, drop dead
  links, add notes where service broker support has been retired
- Redis v4: deduplicate Valkey links, rename to "Tanzu for Valkey on Tanzu Platform"
- "Getting Started with C#" link updated to learn.microsoft.com/dotnet/csharp (v2, v3)

Made-with: Cursor
Copy link
Member

@bart-vmware bart-vmware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an ignore filter for *.mysql.com.

* Configure apps to emit custom metrics to [Loggregator](https://docs.pivotal.io/pivotalcf/2-2/loggregator/architecture.html) system.
* Read custom metrics from the [Loggregator Firehose](https://docs.pivotal.io/pivotalcf/2-2/loggregator/architecture.html#firehose) using a Firehose consumer of their choice, including [community](https://github.com/cloudfoundry/loggregator-release/blob/develop/docs/community-nozzles.md) and third-party nozzles.
* Configure apps to emit custom metrics to [Loggregator](https://docs.cloudfoundry.org/loggregator/architecture.html) system.
* Read custom metrics from the [Loggregator Firehose](https://docs.cloudfoundry.org/loggregator/architecture.html) using a Firehose consumer of their choice, including [community](https://github.com/cloudfoundry/loggregator-release/blob/main/docs/community-nozzles.md) and third-party nozzles.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

public async Task<string> Get()
{
return await _httpClient.GetStringAsync("http://Consul-Register-Example/WeatherForecast");
return await _httpClient.GetStringAsync("http://consul-register-example/WeatherForecast");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be reverted. I've followed the steps and found the instance is registered in Consul under the service name "Consul-Register-Example" (apparently, Steeltoe converts underscores to dashes):

image

Additionally, I noticed the command to add the package needs to be changed from:

dotnet add Steeltoe.Discovery.Consul

to (in alignment with existing docs):

dotnet add package Steeltoe.Discovery.Consul --version 3.2.0

Beware, this entry occurs twice on the page.

I've created #429 to use wildcards for the minor versions.

@bart-vmware
Copy link
Member

Output is looking pretty great now. The 404s at the end are expected, as dotnet/docfx#11012 hasn't been integrated yet.

image

TimHess and others added 3 commits March 3, 2026 09:41
Co-authored-by: Bart Koelman <104792814+bart-vmware@users.noreply.github.com>
- #-loggregator-firehose-architecture
- exclude mysql.com from lychee scan
- restore Consul-Register-Example casing, use case-insensitive exclusion
- fix consul add package example
@TimHess
Copy link
Member

TimHess commented Mar 3, 2026

amqp.org appears to be down today, at this point I'm guessing it's temporary and think we should ignore it
[ERROR] https://www.amqp.org/resources/download

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scan for broken links to external URLs

3 participants