Fix broken external links found with automated link checking#424
Fix broken external links found with automated link checking#424
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
--verbose is needed to see redirect details - locally: - set user-agent locally to avoid 403 on mysql links (doesn't seem to affect CI) - ignore build/docfx-net10-binaries (like playwright readme) - longer host-request-interval and retry-wait-time
30baab7 to
18ceece
Compare
18ceece to
4563611
Compare
- since redirect fixes are already in place in other PR, change verbosity now
- also include a paste-able snippet to bust the cache for a given PR
- external links to - CredHub API, Spring AMQP, and Spring Cloud projects - Broadcom/Pivotal/samples/Microsoft - CredHub/Samples/CircuitBreaker links - Reduce external redirects - Fix double 'the' in fileshares usage docs - Disambiguate Redis/Valkey versions, clarify Thinktecture reference - Fix 'n0t' typo in v3 fileshares docs - TAS SSO→Single Sign-On Co-authored-by: TimHess <3947063+TimHess@users.noreply.github.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
- redirect reductions for docs.microsoft.com and trailing slashes - remove /en-US/ from mozilla links
|
Additional broken link, found in Blazor sources: https://store.education.pivotal.io/confirm-course?courseid=EDU-1180 |
That page wasn't linked anymore, analytics show no traffic in the last year, so I just removed it |
bart-vmware
left a comment
There was a problem hiding this comment.
I've reviewed most of the changes. Most of docs/v2 is still pending.
Co-authored-by: Bart Koelman <104792814+bart-vmware@users.noreply.github.com>
- CredHub "on Tanzu Platform" links updated to Broadcom TechDocs (v2, v3) - Hystrix flow chart anchor corrected from #collapser-flow to #flow-chart (v2, v3) - NuGet profile URL corrected to SteeltoeOSS - CosmosDB, MySQL, PostgreSQL v2/v3: restore original broker names, drop dead links, add notes where service broker support has been retired - Redis v4: deduplicate Valkey links, rename to "Tanzu for Valkey on Tanzu Platform" - "Getting Started with C#" link updated to learn.microsoft.com/dotnet/csharp (v2, v3) Made-with: Cursor
bart-vmware
left a comment
There was a problem hiding this comment.
Please add an ignore filter for *.mysql.com.
docs/docs/v2/management/metrics.md
Outdated
| * Configure apps to emit custom metrics to [Loggregator](https://docs.pivotal.io/pivotalcf/2-2/loggregator/architecture.html) system. | ||
| * Read custom metrics from the [Loggregator Firehose](https://docs.pivotal.io/pivotalcf/2-2/loggregator/architecture.html#firehose) using a Firehose consumer of their choice, including [community](https://github.com/cloudfoundry/loggregator-release/blob/develop/docs/community-nozzles.md) and third-party nozzles. | ||
| * Configure apps to emit custom metrics to [Loggregator](https://docs.cloudfoundry.org/loggregator/architecture.html) system. | ||
| * Read custom metrics from the [Loggregator Firehose](https://docs.cloudfoundry.org/loggregator/architecture.html) using a Firehose consumer of their choice, including [community](https://github.com/cloudfoundry/loggregator-release/blob/main/docs/community-nozzles.md) and third-party nozzles. |
There was a problem hiding this comment.
Loggregator Firehose could link to: https://docs.cloudfoundry.org/loggregator/architecture.html#-loggregator-firehose-architecture
Occurs multiple times.
| public async Task<string> Get() | ||
| { | ||
| return await _httpClient.GetStringAsync("http://Consul-Register-Example/WeatherForecast"); | ||
| return await _httpClient.GetStringAsync("http://consul-register-example/WeatherForecast"); |
There was a problem hiding this comment.
This needs to be reverted. I've followed the steps and found the instance is registered in Consul under the service name "Consul-Register-Example" (apparently, Steeltoe converts underscores to dashes):
Additionally, I noticed the command to add the package needs to be changed from:
dotnet add Steeltoe.Discovery.Consul
to (in alignment with existing docs):
dotnet add package Steeltoe.Discovery.Consul --version 3.2.0
Beware, this entry occurs twice on the page.
I've created #429 to use wildcards for the minor versions.
|
Output is looking pretty great now. The 404s at the end are expected, as dotnet/docfx#11012 hasn't been integrated yet.
|
Co-authored-by: Bart Koelman <104792814+bart-vmware@users.noreply.github.com>
- #-loggregator-firehose-architecture - exclude mysql.com from lychee scan - restore Consul-Register-Example casing, use case-insensitive exclusion - fix consul add package example
|
amqp.org appears to be down today, at this point I'm guessing it's temporary and think we should ignore it |

Addresses broken external URLs across the documentation.
Broken link fixes (~150 files)
docs.pivotal.ioanddocs.vmware.comlinks updated to currenttechdocs.broadcom.compaths for Spring Cloud Services → Application Services, SSO, CredHub, MySQL, Postgres, RabbitMQ, Redis/Valkey, GemFire Native Client, Metric Registrar, Volume Services, CSB (AWS/Azure/GCP), Apps Managerdocs.microsoft.com→learn.microsoft.com,docs.asp.net→learn.microsoft.com,visualstudio.com→visualstudio.microsoft.com; reduced redirects where possible without forcing localizationprojects.spring.io/spring-cloud→spring.io/projects/spring-cloud-*; trailing slash fixesspring-cloud-samples/hystrix-dashboard→Netflix-Skunkworks/hystrix-dashboard,cf-platform-eng/mssql-server-broker→cloudfoundry-attic/mssql-server-broker,cloudfoundry-incubator→cloudfoundrycredhub-api.cfapps.io→docs.cloudfoundry.org/api/credhub/version/main/with corrected anchors (#_overwriting_credential_values,#_permissions)pivotal.io/platform-acceleration-lablinks removedtanzu.vmware.com/gemfire→vmware.com/products/...,tanzu.vmware.com/observability→broadcom.com/products/...,hhttpstypo,start.steeltoe.io/api/config/→/api/uiconfig/Also fixes root-relative markdown links that docfx does not see (inadvertently broken in #363)
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.