Turn unwarranted ABORT cases into FAIL for scs-0117, scs-0123#1063
Merged
Turn unwarranted ABORT cases into FAIL for scs-0117, scs-0123#1063
Conversation
Contributor
|
Case "swift/s3" is also related to #1003. |
Contributor
Author
|
@depressiveRobot actually, I think this is more a case of this: #1004 |
mbuechse
force-pushed
the
fix/scs-0117-abort
branch
from
015d55b to
325a385
Compare
Contributor
Author
|
@depressiveRobot please review this again. It should be fine now. Having branches lying around and accruing bit-rot it not very helpful. |
Signed-off-by: Matthias Büchse <matthias.buechse@alasca.cloud>
Signed-off-by: Matthias Büchse <matthias.buechse@alasca.cloud>
Signed-off-by: Matthias Büchse <matthias.buechse@alasca.cloud>
fkr
force-pushed
the
fix/scs-0117-abort
branch
from
cc99232 to
ca90478
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cases actually warrant FAIL:
Reporting those as ABORT doesn't do the severity of the failures justice.