Skip to content

Allow for dashes in clusterstack names.#221

Open
garloff wants to merge 1 commit intomainfrom
feat/version-parse-with-dashes
Open

Allow for dashes in clusterstack names.#221
garloff wants to merge 1 commit intomainfrom
feat/version-parse-with-dashes

Conversation

@garloff
Copy link
Copy Markdown
Member

@garloff garloff commented Apr 25, 2026

We do this because the mere existence of a
openstack-hosted-control-plane-1-34-v0-sha-0ewkztd tag in the registry confused csctl and prevented us from releasing a new cluster stack.

So, we tolerate dashes in clusterstack names now by being more robust in parsing, So, if we don't have '-v' at the right position in the string spliited by '-', we look for a '-v' further to the right. We then assume that the extra dashes belong to the name and process accordingly.

The string parsing code is not very beautiful, but has been tested successfully.

This fixes #220.

We do this because the mere existence of a
openstack-hosted-control-plane-1-34-v0-sha-0ewkztd tag in the registry
confused csctl and prevented us from releasing a new cluster stack.

So, we tolerate dashes in clusterstack names now by being more robust
in parsing, So, if we don't have '-v' at the right position in the
string spliited by '-', we look for a '-v' further to the right.
We then assume that the extra dashes belong to the name and process
accordingly.

The string parsing code is not very beautiful, but has been tested
successfully.

This fixes #220.

Signed-off-by: Kurt Garloff <kurt@garloff.de>
@garloff garloff requested review from janiskemper and jschoone April 25, 2026 14:09
@garloff garloff self-assigned this Apr 25, 2026
@garloff garloff added bug Something isn't working Container Issues or pull requests relevant for Team 2: Container Infra and Tooling labels Apr 25, 2026
Copy link
Copy Markdown
Member

@janiskemper janiskemper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you would have to change this in the CSO... The vendor directory imports only the package from the CSO.

@garloff
Copy link
Copy Markdown
Member Author

garloff commented May 4, 2026

you would have to change this in the CSO... The vendor directory imports only the package from the CSO.

Sure, that's where the fix belongs. But is it wanted? Then I'm happy to submit it to the CSO ...

@janiskemper
Copy link
Copy Markdown
Member

The libraries from CSO are a dependency of csctl and the vendor directory is auto-generated. Your changes would be silently dropped when there is the next dependency upgrade.

So there are essentially two options:

  • We can add another library based on the CSO's with your changes to this repo
  • We add the change to the CSO directly.

From my point of view, it would be not too bad to do something, because the error message should at least be really helpful to understand the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Container Issues or pull requests relevant for Team 2: Container Infra and Tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

csctl confused on several releases in one OCI repository

2 participants