Fix editData in HTML/UWP extensions allocating too much data#31
Open
AITYunivers wants to merge 1 commit intoSortaCore:masterfrom
Open
Fix editData in HTML/UWP extensions allocating too much data#31AITYunivers wants to merge 1 commit intoSortaCore:masterfrom
AITYunivers wants to merge 1 commit intoSortaCore:masterfrom
Conversation
…he cursor position (in v2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
editData is allocated using
(in v1)
(in v2)
neither of these equations account for the size of eHeader, and in v2 the header not including verStr in it's length.
This PR fixes these by subtracting eHeader and by subtracting 4 (in the Template only as the extensions are v1)