Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates solid-ui’s authentication integration to align with a new uvdsl-oriented session/login contract, while also adjusting TypeScript/Jest configuration to support local “linked repo” development.
Changes:
- Update login calls to a positional
authSession.login(issuer, redirectUrl)signature. - Switch a session-state read in
loginStatusBoxfromauthSession.info.*toauthSession.webId. - Add TS/Jest configuration and Jest mocks intended to stabilize local development when linking to a local
solid-logic.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tsconfig.json | Enables preserveSymlinks and adds baseUrl/paths mapping intended to avoid duplicate rdflib type identities when linking repos. |
| test/mocks/solid-oidc-client-browser.ts | Adds a Jest mock for @uvdsl/solid-oidc-client-browser’s Session API surface. |
| src/v2/components/loginButton/LoginButton.ts | Updates login call site to positional login(issuer, redirectUrl). |
| src/v2/components/footer/Footer.ts | Simplifies event unsubscription logic by removing removeListener fallback. |
| src/login/login.ts | Updates popup login call to positional signature and changes session webId read to authSession.webId. |
| jest.config.mjs | Adds module mappings for local linked solid-logic source and the uvdsl OIDC client mock. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
17
to
21
| moduleNameMapper: { | ||
| '^.+\\.css$': '<rootDir>/__mocks__/styleMock.js' | ||
| '^.+\\.css$': '<rootDir>/__mocks__/styleMock.js', | ||
| '^solid-logic$': '<rootDir>/../solid-logic/src', | ||
| '^@uvdsl/solid-oidc-client-browser$': '<rootDir>/test/mocks/solid-oidc-client-browser.ts' | ||
| }, |
| redirectUrl: locationUrl.href, | ||
| oidcIssuer: issuerUri | ||
| }) | ||
| await authSession.login(issuerUri, locationUrl.href) |
| redirectUrl: locationUrl.href, | ||
| oidcIssuer: issuerUri | ||
| }) | ||
| await authSession.login(issuerUri, locationUrl.href) |
Comment on lines
668
to
674
| box.refresh = function () { | ||
| const sessionInfo = authSession.info | ||
| if (sessionInfo && sessionInfo.webId && sessionInfo.isLoggedIn) { | ||
| me = solidLogicSingleton.store.sym(sessionInfo.webId) | ||
| const webId = authSession.webId | ||
| if (webId) { | ||
| me = solidLogicSingleton.store.sym(webId) | ||
| } else { | ||
| me = null | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Notes - solid-ui (uvdsl contract adoption)
Scope
Update solid-ui to consume the new uvdsl session contract directly and stabilize local integrated development with linked solid-logic.
What changed
{ oidcIssuer, redirectUrl }login(issuer, redirectUrl)addEventListener('sessionStateChange', ...)) where updated.webId/isActive) with fallback only where still needed for integrated migration.Local integrated development notes kept intentionally
tsconfig.jsonincludes settings to avoid duplicate rdflib type identities when solid-ui is linked with local solid-logic:preserveSymlinks: truebaseUrl+pathsmapping forrdflibThis avoids false-positive type errors like
LiveStore is not assignable to IndexedFormulacaused by two rdflib type origins.Jest stabilization for local linked repos
solid-logicto source in Jest to avoid loading webpack bundle output during tests.@uvdsl/solid-oidc-client-browserfor Jest/JSDOM to avoid ESM/import.meta runtime issues.Integration outcome
Suggested commit message
Title
feat(auth): adopt uvdsl session contract in solid-ui and stabilize local linked dev
Body
Suggested post-validation cleanup commit (optional)
Title
refactor(auth): remove remaining transitional auth fallbacks in solid-ui
Body