Skip to content

fix version #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SharonStrats wants to merge 1 commit into from
Closed

fix version #563

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@
"preversion": "npm run lint && npm run typecheck && npm test",
"postversion": "git push origin main --follow-tags",
"watch": "npm run build-version && babel src -d dist --source-maps --extensions '.ts,.js' --watch",
"postinstall": "npm run build-version",
"prestart": "npm run build-version",
Comment on lines +35 to +36
Copy link

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a postinstall hook to run build-version will break installs for consumers of the published npm package: build-version depends on timestamp.sh and writes src/versionInfo.ts, but the published package only includes dist/, README.md, and LICENSE (no src/ or timestamp.sh). Consider removing postinstall, or making it conditional (only run in a git checkout where src/ + timestamp.sh exist), or generating version info during build/pack so install doesn’t need to run scripts.

Suggested change
"postinstall": "npm run build-version",
"prestart": "npm run build-version",
"postinstall": "if [ -f timestamp.sh ] && [ -d src ]; then npm run build-version; else echo \"Skipping build-version during postinstall: sources not available.\"; fi",
"prestart": "if [ -f timestamp.sh ] && [ -d src ]; then npm run build-version; else echo \"Skipping build-version before start: sources not available.\"; fi",

Copilot uses AI. Check for mistakes.
"start": "webpack serve --config webpack.dev.config.mjs --open"
},
"repository": {
Expand Down
Loading